Issue 1109873003: Fix VKEY determination for non-US layouts under Ozone.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1109873003: Fix VKEY determination for non-US layouts under Ozone. (Closed)

Created:
5 years, 8 months ago by kpschoedel

Modified:
5 years, 8 months ago

Reviewers:
spang

CC:
chromium-reviews, kalyank, jdduke+watch_chromium.org, ozone-reviews_chromium.org, tdresser+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@2357

Target Ref:
refs/pending/branch-heads/2357

Project:
chromium

Visibility:
Public.

More Reviews

Description

Fix VKEY determination for non-US layouts under Ozone. We attempt to match Windows behaviour for the value of VKEY on a keystroke. Some XKB layouts generate characters for AltGr+key combinations that are not present in the reference (Windows-based) sources, which led to mismtaches in the mappings, and incorrect VKEY values for those keys. To avoid this, we match on any AltGr+key result in cases the reference has none. The corresponding test is revised to use a valid dummy character for those cases, rather than 'NoSymbol'. TBR=spang BUG=480529 Review URL: https://codereview.chromium.org/1100393005 Cr-Commit-Position: refs/heads/master@{#326695} (cherry picked from commit e63d52e7a86a8cb5f6703b1ae98f44be1a85de35) Committed: https://chromium.googlesource.com/chromium/src/+/9653b26842ab4037b88091993b8dcbe0283e40ce

Patch Set 1 #

Created: 5 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+56 lines, -68 lines)			Patch
	M	ui/events/ozone/layout/xkb/xkb_keyboard_layout_engine.cc	View		13 chunks	+37 lines, -49 lines	0 comments	Download
	M	ui/events/ozone/layout/xkb/xkb_keyboard_layout_engine_unittest.cc	View		14 chunks	+19 lines, -19 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

kpschoedel

5 years, 8 months ago (2015-04-27 17:25:19 UTC) #1

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
9653b26842ab4037b88091993b8dcbe0283e40ce (presubmit successful).

Expand Messages | Collapse Messages