Chromium Code Reviews

Issue 1100393005: Fix VKEY determination for non-US layouts under Ozone. (Closed)

Created:
5 years, 8 months ago by kpschoedel
Modified:
5 years, 8 months ago
Reviewers:
spang
CC:
chromium-reviews, kalyank, jdduke+watch_chromium.org, ozone-reviews_chromium.org, tdresser+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix VKEY determination for non-US layouts under Ozone. We attempt to match Windows behaviour for the value of VKEY on a keystroke. Some XKB layouts generate characters for AltGr+key combinations that are not present in the reference (Windows-based) sources, which led to mismtaches in the mappings, and incorrect VKEY values for those keys. To avoid this, we match on any AltGr+key result in cases the reference has none. The corresponding test is revised to use a valid dummy character for those cases, rather than 'NoSymbol'. BUG=480529 Committed: https://crrev.com/e63d52e7a86a8cb5f6703b1ae98f44be1a85de35 Cr-Commit-Position: refs/heads/master@{#326695}

Patch Set 1 #

Unified diffs Side-by-side diffs Stats (+56 lines, -68 lines)
M ui/events/ozone/layout/xkb/xkb_keyboard_layout_engine.cc View 13 chunks +37 lines, -49 lines 0 comments
M ui/events/ozone/layout/xkb/xkb_keyboard_layout_engine_unittest.cc View 14 chunks +19 lines, -19 lines 0 comments

Messages

Total messages: 11 (4 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1100393005/1
5 years, 8 months ago (2015-04-23 23:26:06 UTC) #2
kpschoedel
5 years, 8 months ago (2015-04-23 23:28:20 UTC) #4
spang
lgtm
5 years, 8 months ago (2015-04-23 23:37:56 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 8 months ago (2015-04-23 23:48:13 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1100393005/1
5 years, 8 months ago (2015-04-23 23:58:17 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-23 23:59:24 UTC) #10
commit-bot: I haz the power
5 years, 8 months ago (2015-04-24 00:00:40 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e63d52e7a86a8cb5f6703b1ae98f44be1a85de35
Cr-Commit-Position: refs/heads/master@{#326695}

Powered by Google App Engine