Issue 11098075: Automagically start up selenium server for Safari.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11098075: Automagically start up selenium server for Safari. (Closed)

Created:
8 years, 2 months ago by Emily Fortuna

Modified:
8 years, 2 months ago

Reviewers:
gram, Mads Ager (google)

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Automagically start up selenium server for Safari. Committed: https://code.google.com/p/dart/source/detail?r=13569

Patch Set 2 : #

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -3 lines)			Patch
	M	tools/testing/dart/test_options.dart	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
	M	tools/testing/dart/test_runner.dart	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

gram

lgtm after my comment is addressed. https://codereview.chromium.org/11098075/diff/1/tools/testing/dart/test_options.dart File tools/testing/dart/test_options.dart (left): https://codereview.chromium.org/11098075/diff/1/tools/testing/dart/test_options.dart#oldcode475 tools/testing/dart/test_options.dart:475: configuration['runtime'] == 'ff'; ...

8 years, 2 months ago (2012-10-11 18:22:05 UTC) #2

Emily Fortuna

https://codereview.chromium.org/11098075/diff/1/tools/testing/dart/test_options.dart File tools/testing/dart/test_options.dart (left): https://codereview.chromium.org/11098075/diff/1/tools/testing/dart/test_options.dart#oldcode475 tools/testing/dart/test_options.dart:475: configuration['runtime'] == 'ff'; On 2012/10/11 18:22:05, gram wrote: > ...

8 years, 2 months ago (2012-10-11 18:24:33 UTC) #3

Mads Ager (google)

8 years, 2 months ago (2012-10-11 18:53:24 UTC) #4

LGTM, thanks Emily.

Was this broken for Safari before? The buildbot seemed to work for Safari with
the broken code, so I wonder if we don't need to special case for Safari
anymore?

Expand Messages | Collapse Messages

Issue 11098075: Automagically start up selenium server for Safari. (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Messages