Chromium Code Reviews
Help | Chromium Project | Sign in
(39)

Issue 11098023: Make child process errors kill gyp when parallel processing is on. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 6 months ago by dmazzoni
Modified:
1 year, 6 months ago
Reviewers:
scottmg
CC:
gyp-developer_googlegroups.com
Base URL:
http://git.chromium.org/external/gyp.git@master
Visibility:
Public.

Description

Make Ctrl+C kill gyp when parallel processing is on.

Manually tested these cases:
* Normal success case
* Ctrl+C during input file processing
* Syntax error in input file
* Ctrl+C during ninja generation
* Bug in Python code in ninja generation

Solution to Ctrl+C adapted from John Reese's solution here:
http://stackoverflow.com/questions/1408356/keyboard-interrupts-with-pythons-multiprocessing-pool

Patch Set 1 #

Total comments: 1

Patch Set 2 : Also fix syntax error handling #

Unified diffs Side-by-side diffs Delta from patch set Stats (+96 lines, -59 lines) Lint Patch
M pylib/gyp/generator/ninja.py View 3 chunks +16 lines, -5 lines 0 comments ? errors Download
M pylib/gyp/input.py View 1 4 chunks +80 lines, -54 lines 0 comments ? errors Download
Trybot results:
Commit:

Messages

Total messages: 4
dmazzoni
1 year, 6 months ago #1
scottmg
Would it maybe be better to handle the children failing/exiting instead so that syntax errors ...
1 year, 6 months ago #2
dmazzoni
On 2012/10/09 18:12:54, scottmg wrote: > Would it maybe be better to handle the children ...
1 year, 6 months ago #3
scottmg
1 year, 6 months ago #4
lgtm
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1275:d14800f88434