Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 1109793003: [Extern Generation] Normify extern enum property names (Closed)

Created:
5 years, 7 months ago by Devlin
Modified:
5 years, 7 months ago
Reviewers:
Dan Beam
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Extern Generation] Normify extern enum property names We are now normifying extension enum property names as part of crbug.com/463184. Update the extern generator to share this same pattern. BUG=469920 Committed: https://crrev.com/ecf3ed6ae14fbf51a71be8a41df8b505656d5858 Cr-Commit-Position: refs/heads/master@{#327523}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -1 line) Patch
M tools/json_schema_compiler/js_externs_generator.py View 2 chunks +16 lines, -1 line 2 comments Download
M tools/json_schema_compiler/js_externs_generator_test.py View 2 chunks +17 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Devlin
5 years, 7 months ago (2015-04-27 23:52:27 UTC) #2
Dan Beam
lgtm https://codereview.chromium.org/1109793003/diff/1/tools/json_schema_compiler/js_externs_generator.py File tools/json_schema_compiler/js_externs_generator.py (right): https://codereview.chromium.org/1109793003/diff/1/tools/json_schema_compiler/js_externs_generator.py#newcode76 tools/json_schema_compiler/js_externs_generator.py:76: def get_property_name(e): nit: def scare_small_children(e): https://google-styleguide.googlecode.com/svn/trunk/cppguide.html#Macro_Names
5 years, 7 months ago (2015-04-28 00:21:46 UTC) #3
Devlin
https://codereview.chromium.org/1109793003/diff/1/tools/json_schema_compiler/js_externs_generator.py File tools/json_schema_compiler/js_externs_generator.py (right): https://codereview.chromium.org/1109793003/diff/1/tools/json_schema_compiler/js_externs_generator.py#newcode76 tools/json_schema_compiler/js_externs_generator.py:76: def get_property_name(e): On 2015/04/28 00:21:46, Dan Beam wrote: > ...
5 years, 7 months ago (2015-04-28 00:25:08 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1109793003/1
5 years, 7 months ago (2015-04-29 17:53:43 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-04-29 18:07:32 UTC) #7
commit-bot: I haz the power
5 years, 7 months ago (2015-04-29 18:09:21 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ecf3ed6ae14fbf51a71be8a41df8b505656d5858
Cr-Commit-Position: refs/heads/master@{#327523}

Powered by Google App Engine
This is Rietveld 408576698