[Extern Generation] Normify extern enum property names

tools/json_schema_compiler/js_externs_generator.py

 # Copyright 2015 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 """
 Generator that produces an externs file for the Closure Compiler.
 Note: This is a work in progress, and generated externs may require tweaking.
 
 See https://developers.google.com/closure/compiler/docs/api-tutorial3#externs
 """
 
 from code import Code
 from model import *
 from schema_util import *
 
 import os
 from datetime import datetime
+import re
 
 LICENSE = ("""// Copyright %s The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 """ % datetime.now().year)
 
 class JsExternsGenerator(object):
   def Generate(self, namespace):
     return _Generator(namespace).Generate()
 
@@ skipping 37 matching lines @@
 
   def _GenerateEnumJsDoc(self, js_type):
     """ Given an Enum Type object, returns the Code for the enum's definition.
     """
     c = Code()
     (c.Sblock(line='/**', line_prefix=' * ')
       .Append('@enum {string}')
       .Append(self._GenerateSeeLink('type', js_type.simple_name))
       .Eblock(' */'))
     c.Append('chrome.%s.%s = {' % (self._namespace.name, js_type.name))
+
+    def get_property_name(e):

[Dan Beam, 2015/04/28 00:21:46]

nit: def scare_small_children(e):
https://google-styleguide.googlecode.com/svn/trunk/cppguide.html#Macro_Names

[Devlin, 2015/04/28 00:25:08]

Haha I don't think I've ever seen that (phrasing, I knew the rule)...

That said, this isn't a macro - it's a python function. :)

+      # Enum properties are normified to be in ALL_CAPS_STYLE.
+      # Assume enum '1ring-rulesThemAll'.
+      # Transform to '1ring-rules_Them_All'.
+      e = re.sub(r'([a-z])([A-Z])', r'\1_\2', e)
+      # Transform to '1ring_rules_Them_All'.
+      e = re.sub(r'\W', '_', e)
+      # Transform to '_1ring_rules_Them_All'.
+      e = re.sub(r'^(\d)', r'_\1', e)
+      # Transform to '_1RING_RULES_THEM_ALL'.
+      return e.upper()
+
     c.Append('\n'.join(
-        ["  %s: '%s'," % (v.name, v.name) for v in js_type.enum_values]))
+        ["  %s: '%s'," % (get_property_name(v.name), v.name)
+            for v in js_type.enum_values]))
     c.Append('};')
     return c
 
   def _IsTypeConstructor(self, js_type):
     """Returns true if the given type should be a @constructor. If this returns
        false, the type is a typedef.
     """
     return any(prop.type_.property_type is PropertyType.FUNCTION
                for prop in js_type.properties.values())
 
@@ skipping 221 matching lines @@
     """Generates a @see link for a given API 'object' (type, method, or event).
     """
 
     # NOTE(devlin): This is kind of a hack. Some APIs will be hosted on
     # developer.chrome.com/apps/ instead of /extensions/, and some APIs have
     # '.'s in them (like app.window), which should resolve to 'app_window'.
     # Luckily, the doc server has excellent url resolution, and knows exactly
     # what we mean. This saves us from needing any complicated logic here.
     return ('@see https://developer.chrome.com/extensions/%s#%s-%s' %
                 (self._namespace.name, object_type, object_name))