Use of base::StringPairs appropriately in nacl.

Use of base::StringPairs appropriately in nacl.

Bescause base/strings/string_split.h defines:
typedef std::vector<std::pair<std::string, std::string> > StringPairs;

BUG=412250
Committed: https://crrev.com/ab03ab78e51ca34b3cf2552c8004fd2aebfa0195
Cr-Commit-Position: refs/heads/master@{#327452}

[payal.pandey, 2015-04-27 08:23:08]

payal.pandey@samsung.com changed reviewers:
+ sehr@chromium.org, teravest@chromium.org

[payal.pandey, 2015-04-27 08:23:09]

Please have a look, Thanks

[teravest, 2015-04-27 14:13:48]

teravest@chromium.org changed reviewers:
+ bbudge@chromium.org

[teravest, 2015-04-27 14:13:49]

-teravest +bbudge

[teravest, 2015-04-27 14:13:58]

teravest@chromium.org changed reviewers:
- teravest@chromium.org

[bbudge, 2015-04-27 14:37:26]

Could you change other usages of std::vector<std::pair<std::string, std:string>>
to match?

https://codereview.chromium.org/1109723002/diff/1/components/nacl/common/nacl...
File components/nacl/common/nacl_types.h (right):

https://codereview.chromium.org/1109723002/diff/1/components/nacl/common/nacl...
components/nacl/common/nacl_types.h:124: NaClAppProcessType process_type);
If you're going to change this here, then you should also change the function
definition:
https://code.google.com/p/chromium/codesearch#chromium/src/components/nacl/co...

https://codereview.chromium.org/1109723002/diff/1/components/nacl/common/nacl...
components/nacl/common/nacl_types.h:134: std::vector<std::pair<std::string,
std::string> > resource_files_to_prefetch;
This should be changed too. And there are usages in json_manifest.cc and
ppb_nacl_private_impl.cc that should also be changed to match.

[payal.pandey, 2015-04-28 06:15:01]

Review comments incorporated.

Modified all files in nacl folder,
those have std::vector<std::pair<std::string, std::string> >

Please have a look, Thanks.

[bbudge, 2015-04-28 14:11:50]

lgtm

[payal.pandey, 2015-04-28 14:12:25]

The CQ bit was checked by payal.pandey@samsung.com

[commit-bot: I haz the power, 2015-04-28 14:12:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1109723002/20001

[commit-bot: I haz the power, 2015-04-28 14:33:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-04-28 14:33:44]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[sehr, 2015-04-28 18:26:54]

lgtm

[payal.pandey, 2015-04-29 05:22:56]

The CQ bit was checked by payal.pandey@samsung.com

[commit-bot: I haz the power, 2015-04-29 05:23:26]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1109723002/20001

[payal.pandey, 2015-04-29 05:24:40]

The CQ bit was checked by payal.pandey@samsung.com

[commit-bot: I haz the power, 2015-04-29 05:25:38]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1109723002/20001

[commit-bot: I haz the power, 2015-04-29 08:53:45]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-04-29 08:54:49]

Patchset 2 (id:??) landed as
https://crrev.com/ab03ab78e51ca34b3cf2552c8004fd2aebfa0195
Cr-Commit-Position: refs/heads/master@{#327452}