components/nacl/renderer/json_manifest.cc - Issue 1109723002: Use of base::StringPairs appropriately in nacl.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/nacl/renderer/json_manifest.cc

Issue 1109723002: Use of base::StringPairs appropriately in nacl. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Incorporated review comments. Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/nacl/renderer/json_manifest.cc

diff --git a/components/nacl/renderer/json_manifest.cc b/components/nacl/renderer/json_manifest.cc

index 56a4b2a2352cd36f138de148484a52095b865817..abcd92e20847dc55fe36010a2f372de68eb17854 100644

--- a/components/nacl/renderer/json_manifest.cc

+++ b/components/nacl/renderer/json_manifest.cc

@@ -442,8 +442,7 @@ bool JsonManifest::GetProgramURL(std::string* full_url,

return true;

}

-void JsonManifest::GetPrefetchableFiles(

- std::vector<std::pair<std::string, std::string> >* out_files) const {

+void JsonManifest::GetPrefetchableFiles(base::StringPairs* out_files) const {

const Json::Value& files = dictionary_[kFilesKey];

if (!files.isObject())

return;