Oilpan: have History on the heap by default.

Oilpan: have History on the heap by default.

R=haraken
BUG=479467
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=194390

[sof, 2015-04-24 12:28:19]

sigbjornf@opera.com changed reviewers:
+ oilpan-reviews@chromium.org

[sof, 2015-04-24 12:28:20]

Please take a look.

[haraken, 2015-04-24 12:43:51]

haraken@chromium.org changed reviewers:
+ haraken@chromium.org

[haraken, 2015-04-24 12:43:52]

LGTM

https://codereview.chromium.org/1109493003/diff/1/Source/core/frame/History.h
File Source/core/frame/History.h (right):

https://codereview.chromium.org/1109493003/diff/1/Source/core/frame/History.h...
Source/core/frame/History.h:45: WILL_BE_USING_GARBAGE_COLLECTED_MIXIN(History);

WILL_BE_USING_GARBAGE_COLLECTED_MIXIN => USING_GARBAGE_COLLECTED_MIXIN

Here, again, we need to make sure that it is safe to move History to Oilpan
without moving DOMWindowProperty to Oilpan.

The only guy who traces DOMWindowProperty is LocalDOMWindow, and the
LocalDOMWindow is tracing the DOMWindowProperty weakly (not strongly). Thus it
is safe to move History to Oilpan without moving DOMWindowProperty as long as we
keep the pointer-clear-out code as is.

So this CL looks safe.

[sof, 2015-04-24 12:46:41]

https://codereview.chromium.org/1109493003/diff/1/Source/core/frame/History.h
File Source/core/frame/History.h (right):

https://codereview.chromium.org/1109493003/diff/1/Source/core/frame/History.h...
Source/core/frame/History.h:45: WILL_BE_USING_GARBAGE_COLLECTED_MIXIN(History);
On 2015/04/24 12:43:52, haraken wrote:
> 
> WILL_BE_USING_GARBAGE_COLLECTED_MIXIN => USING_GARBAGE_COLLECTED_MIXIN
> 
> Here, again, we need to make sure that it is safe to move History to Oilpan
> without moving DOMWindowProperty to Oilpan.
> 
> The only guy who traces DOMWindowProperty is LocalDOMWindow, and the
> LocalDOMWindow is tracing the DOMWindowProperty weakly (not strongly). Thus it
> is safe to move History to Oilpan without moving DOMWindowProperty as long as
we
> keep the pointer-clear-out code as is.
> 
> So this CL looks safe.
> 

I'm not quite sure what to make of the "=>" at the top -- it needs to be
WILL_BE, as DOMWindowProperty is WillBeGarbageCollectedMixin.

[haraken, 2015-04-24 12:47:29]

https://codereview.chromium.org/1109493003/diff/1/Source/core/frame/History.h
File Source/core/frame/History.h (right):

https://codereview.chromium.org/1109493003/diff/1/Source/core/frame/History.h...
Source/core/frame/History.h:45: WILL_BE_USING_GARBAGE_COLLECTED_MIXIN(History);
On 2015/04/24 12:46:41, sof wrote:
> On 2015/04/24 12:43:52, haraken wrote:
> > 
> > WILL_BE_USING_GARBAGE_COLLECTED_MIXIN => USING_GARBAGE_COLLECTED_MIXIN
> > 
> > Here, again, we need to make sure that it is safe to move History to Oilpan
> > without moving DOMWindowProperty to Oilpan.
> > 
> > The only guy who traces DOMWindowProperty is LocalDOMWindow, and the
> > LocalDOMWindow is tracing the DOMWindowProperty weakly (not strongly). Thus
it
> > is safe to move History to Oilpan without moving DOMWindowProperty as long
as
> we
> > keep the pointer-clear-out code as is.
> > 
> > So this CL looks safe.
> > 
> 
> I'm not quite sure what to make of the "=>" at the top -- it needs to be
> WILL_BE, as DOMWindowProperty is WillBeGarbageCollectedMixin.

ah, right. We need to drop the WillBe when dropping the WillBe from
DOMWindowProperty.

[sof, 2015-04-24 13:12:05]

The CQ bit was checked by sigbjornf@opera.com

[commit-bot: I haz the power, 2015-04-24 13:12:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1109493003/1

[commit-bot: I haz the power, 2015-04-24 13:17:11]

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=194390