Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(946)

Unified Diff: Source/core/frame/History.h

Issue 1109493003: Oilpan: have History on the heap by default. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/events/PopStateEvent.cpp ('k') | Source/core/frame/History.idl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/frame/History.h
diff --git a/Source/core/frame/History.h b/Source/core/frame/History.h
index 12057e486d715a616108d72dc46ff64bfd8c2c89..80a0de1aa92b62a5c97436674bbb5569ae25e544 100644
--- a/Source/core/frame/History.h
+++ b/Source/core/frame/History.h
@@ -32,8 +32,6 @@
#include "core/frame/DOMWindowProperty.h"
#include "platform/heap/Handle.h"
#include "wtf/Forward.h"
-#include "wtf/PassRefPtr.h"
-#include "wtf/RefCounted.h"
namespace blink {
@@ -42,13 +40,13 @@ class KURL;
class ExecutionContext;
class ExceptionState;
-class History final : public RefCountedWillBeGarbageCollectedFinalized<History>, public ScriptWrappable, public DOMWindowProperty {
+class History final : public GarbageCollectedFinalized<History>, public ScriptWrappable, public DOMWindowProperty {
DEFINE_WRAPPERTYPEINFO();
WILL_BE_USING_GARBAGE_COLLECTED_MIXIN(History);
haraken 2015/04/24 12:43:52 WILL_BE_USING_GARBAGE_COLLECTED_MIXIN => USING_GAR
sof 2015/04/24 12:46:41 I'm not quite sure what to make of the "=>" at the
haraken 2015/04/24 12:47:28 ah, right. We need to drop the WillBe when droppin
public:
- static PassRefPtrWillBeRawPtr<History> create(LocalFrame* frame)
+ static History* create(LocalFrame* frame)
{
- return adoptRefWillBeNoop(new History(frame));
+ return new History(frame);
}
unsigned length() const;
« no previous file with comments | « Source/core/events/PopStateEvent.cpp ('k') | Source/core/frame/History.idl » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698