Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 1109453005: [Chromoting] Extract shared viewport code into viewport.js. (Closed)

Created:
5 years, 8 months ago by garykac
Modified:
5 years, 8 months ago
Reviewers:
kelvinp
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Chromoting] Extract shared viewport code into viewport.js. Currently the shared code is located in desktop_viewport.js, which means that this file needs to be included by the AppRemoting builds. But including that file also brings in a bunch of DesktopRemoting stuff as well. This cl extracts out the shared code into viewport.js (and moves the unittests as well) so that we can more easily exclude the desktop code from the AppRemoting code in a following cl. BUG= Committed: https://crrev.com/828a33d42acb4e738cba6d6b2cd342a37dcdfc83 Cr-Commit-Position: refs/heads/master@{#327053}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+212 lines, -519 lines) Patch
M remoting/remoting_webapp_files.gypi View 2 chunks +2 lines, -1 line 0 comments Download
M remoting/webapp/app_remoting/js/app_connected_view.js View 1 chunk +1 line, -1 line 0 comments Download
A remoting/webapp/base/js/viewport.js View 1 chunk +153 lines, -0 lines 0 comments Download
A + remoting/webapp/base/js/viewport_unittest.js View 8 chunks +53 lines, -53 lines 0 comments Download
M remoting/webapp/crd/js/desktop_viewport.js View 2 chunks +1 line, -134 lines 0 comments Download
D remoting/webapp/crd/js/desktop_viewport_unittest.js View 1 chunk +0 lines, -329 lines 0 comments Download
M remoting/webapp/files.gni View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
garykac
5 years, 8 months ago (2015-04-24 22:13:35 UTC) #2
kelvinp
lgtm
5 years, 8 months ago (2015-04-24 22:16:34 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1109453005/1
5 years, 8 months ago (2015-04-27 15:32:40 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-27 16:23:56 UTC) #6
commit-bot: I haz the power
5 years, 8 months ago (2015-04-27 16:24:47 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/828a33d42acb4e738cba6d6b2cd342a37dcdfc83
Cr-Commit-Position: refs/heads/master@{#327053}

Powered by Google App Engine
This is Rietveld 408576698