Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(308)

Issue 1109453002: Re-roll GN to 326666 and fix GN-related bugs. (Closed)

Created:
5 years, 8 months ago by Dirk Pranke
Modified:
5 years, 8 months ago
Reviewers:
brettw, horo
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Re-roll GN to 326666 and fix GN-related bugs. Fix bugs related to the latest GN roll. 1) the new GN binary will return an error if you pass it a file it doesn't know anything about in 'gn refs'. 2) for some reason with the new GN binary we're triggering a code path in gyp_flag_compare.py that wasn't running before, and that code path was busted. TBR=brettw@chromium.org BUG= CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_chromium_gn_dbg;tryserver.chromium.mac:mac_chromium_gn_rel,mac_chromium_gn_dbg;tryserver.chromium.win:win8_chromium_gn_rel Committed: https://crrev.com/0b3b788227da8865280c19eb2aadddfe03ff71b4 Cr-Commit-Position: refs/heads/master@{#326736}

Patch Set 1 #

Patch Set 2 : delete stray blank line #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -3 lines) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
M tools/gn/bin/gyp_flag_compare.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/mb/mb.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/mb/mb_unittest.py View 1 1 chunk +18 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
Dirk Pranke
5 years, 8 months ago (2015-04-24 01:57:31 UTC) #2
horo
lgtm
5 years, 8 months ago (2015-04-24 02:14:37 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1109453002/20001
5 years, 8 months ago (2015-04-24 02:17:19 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1109453002/20001
5 years, 8 months ago (2015-04-24 03:26:38 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 8 months ago (2015-04-24 03:38:22 UTC) #9
commit-bot: I haz the power
5 years, 8 months ago (2015-04-24 03:39:11 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/0b3b788227da8865280c19eb2aadddfe03ff71b4
Cr-Commit-Position: refs/heads/master@{#326736}

Powered by Google App Engine
This is Rietveld 408576698