tools/mb/mb.py - Issue 1109453002: Re-roll GN to 326666 and fix GN-related bugs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/mb/mb.py

Issue 1109453002: Re-roll GN to 326666 and fix GN-related bugs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: delete stray blank line Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/mb/mb.py

diff --git a/tools/mb/mb.py b/tools/mb/mb.py

index 5d6fe1b7e075184d96532d8343e56d51fe8e4e77..0b5775e9f2069fb887144b1deda0ef700a8763d3 100755

--- a/tools/mb/mb.py

+++ b/tools/mb/mb.py

@@ -430,7 +430,7 @@ class MetaBuildWrapper(object):

cmd = self.GNCmd('refs', self.args.path[0]) + [

'//' + f, '--type=executable', '--all', '--as=output']

ret, out, _ = self.Run(cmd)

- if ret:

+ if ret and not 'The input matches no targets' in out:

self.WriteFailureAndRaise('gn refs returned %d: %s' % (ret, out),

output_path)

« no previous file with comments | « tools/gn/bin/gyp_flag_compare.py ('k') | tools/mb/mb_unittest.py » ('j') | no next file with comments »