lib/html/templates/html/dart2js/factoryprovider_ShadowRoot.darttemplate - Issue 11094082: Convert legacy 'native code' to JS-forms in dart:html

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: lib/html/templates/html/dart2js/factoryprovider_ShadowRoot.darttemplate

Issue 11094082: Convert legacy 'native code' to JS-forms in dart:html (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 8 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« lib/html/templates/html/dart2js/factoryprovider_CSSMatrix.darttemplate ('K') | « lib/html/templates/html/dart2js/factoryprovider_OptionElement.darttemplate ('k') | lib/html/templates/html/dart2js/factoryprovider_SharedWorker.darttemplate » ('j') | lib/html/templates/html/impl/impl_Element.darttemplate » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: lib/html/templates/html/dart2js/factoryprovider_ShadowRoot.darttemplate

diff --git a/lib/html/templates/html/dart2js/factoryprovider_ShadowRoot.darttemplate b/lib/html/templates/html/dart2js/factoryprovider_ShadowRoot.darttemplate

index c1f081edebd73eb13427a3cabe5ef7f3a0804ddb..7d82ab5cc7ceaf97a8b9d61a409c83c5e3bb34bd 100644

--- a/lib/html/templates/html/dart2js/factoryprovider_ShadowRoot.darttemplate

+++ b/lib/html/templates/html/dart2js/factoryprovider_ShadowRoot.darttemplate

@@ -3,7 +3,7 @@

// BSD-style license that can be found in the LICENSE file.

class $FACTORYPROVIDER {

- static ShadowRoot createShadowRoot(Element host) native '''

- return new (window.ShadowRoot || window.WebKitShadowRoot)(host);

- ''';

+ static ShadowRoot createShadowRoot(Element host) =>

floitsch 2012/10/12 13:40:17 move "=>" to next line.

sra1 2012/10/12 21:39:47 To be resolved outside of this CL.

+ JS('ShadowRoot',

+ 'new (window.ShadowRoot || window.WebKitShadowRoot)(#)', host);

}