lib/html/templates/html/dart2js/factoryprovider_CSSMatrix.darttemplate - Issue 11094082: Convert legacy 'native code' to JS-forms in dart:html

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: lib/html/templates/html/dart2js/factoryprovider_CSSMatrix.darttemplate

Issue 11094082: Convert legacy 'native code' to JS-forms in dart:html (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 8 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« lib/html/scripts/systemhtml.py ('K') | « lib/html/templates/html/dart2js/factoryprovider_Blob.darttemplate ('k') | lib/html/templates/html/dart2js/factoryprovider_DataView.darttemplate » ('j') | lib/html/templates/html/dart2js/factoryprovider_ShadowRoot.darttemplate » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: lib/html/templates/html/dart2js/factoryprovider_CSSMatrix.darttemplate

diff --git a/lib/html/templates/html/dart2js/factoryprovider_CSSMatrix.darttemplate b/lib/html/templates/html/dart2js/factoryprovider_CSSMatrix.darttemplate

index 6abf326544596c851846e366d772c43e986f6708..261bd5c8606786f58b20cb9be22fd8543b88d86e 100644

--- a/lib/html/templates/html/dart2js/factoryprovider_CSSMatrix.darttemplate

+++ b/lib/html/templates/html/dart2js/factoryprovider_CSSMatrix.darttemplate

@@ -3,6 +3,6 @@

// BSD-style license that can be found in the LICENSE file.

class $FACTORYPROVIDER {

- static CSSMatrix createCSSMatrix([String cssValue = '']) native

- 'return new WebKitCSSMatrix(cssValue);';

+ static CSSMatrix createCSSMatrix([String cssValue = '']) =>

floitsch 2012/10/12 13:40:17 by convention we put "=>" into the next line.

sra1 2012/10/12 21:39:47 I disagree that this is the convention. In pkg, it

+ JS('CSSMatrix', 'new WebKitCSSMatrix(#)', cssValue);

}