Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(603)

Unified Diff: lib/html/src/dart2js_FactoryProviders.dart

Issue 11094082: Convert legacy 'native code' to JS-forms in dart:html (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: lib/html/src/dart2js_FactoryProviders.dart
diff --git a/lib/html/src/dart2js_FactoryProviders.dart b/lib/html/src/dart2js_FactoryProviders.dart
index d17e0f0c7cce92c3ca02650de9cb262dab7d3d83..51e0f12a0f779cda74b6e89da66f12a983da32e6 100644
--- a/lib/html/src/dart2js_FactoryProviders.dart
+++ b/lib/html/src/dart2js_FactoryProviders.dart
@@ -4,23 +4,23 @@
class _AudioContextFactoryProvider {
- static AudioContext createAudioContext() native '''
- var constructor = window.AudioContext || window.webkitAudioContext;
- return new constructor();
-''';
+ static AudioContext createAudioContext() {
+ return JS('AudioContext',
+ 'new (window.AudioContext || window.webkitAudioContext)()');
+ }
}
class _PointFactoryProvider {
- static Point createPoint(num x, num y) native
- 'return new WebKitPoint(x, y);';
+ static Point createPoint(num x, num y) =>
+ JS('Point', 'new WebKitPoint(#, #)', x, y);
}
class _WebSocketFactoryProvider {
- static WebSocket createWebSocket(String url) native
- '''return new WebSocket(url);''';
+ static WebSocket createWebSocket(String url) =>
+ JS('WebSocket', 'new WebSocket(#)', url);
}
class _TextFactoryProvider {
- static Text createText(String data) native
- "return document.createTextNode(data);";
+ static Text createText(String data) =>
+ JS('Text', 'document.createTextNode(#)', data);
}

Powered by Google App Engine
This is Rietveld 408576698