net/ssl/ssl_cipher_suite_names_unittest.cc - Issue 1109283003: Change connection info strings (e.g. SHA-1 cert warnings) to be more clear.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/ssl/ssl_cipher_suite_names_unittest.cc

Issue 1109283003: Change connection info strings (e.g. SHA-1 cert warnings) to be more clear. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Update unit test. Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/ssl/ssl_cipher_suite_names_unittest.cc

diff --git a/net/ssl/ssl_cipher_suite_names_unittest.cc b/net/ssl/ssl_cipher_suite_names_unittest.cc

index 9a5b4a8f8634ba0d84b85559a6556790ff8391c6..6334c30d686aa8d68462c5ee16c824c481599045 100644

--- a/net/ssl/ssl_cipher_suite_names_unittest.cc

+++ b/net/ssl/ssl_cipher_suite_names_unittest.cc

@@ -18,7 +18,7 @@ TEST(CipherSuiteNamesTest, Basic) {

SSLCipherSuiteToStrings(&key_exchange, &cipher, &mac, &is_aead, 0xc001);

EXPECT_STREQ("ECDH_ECDSA", key_exchange);

EXPECT_STREQ("NULL", cipher);

- EXPECT_STREQ("SHA1", mac);

+ EXPECT_STREQ("HMAC-SHA1", mac);

EXPECT_FALSE(is_aead);

SSLCipherSuiteToStrings(&key_exchange, &cipher, &mac, &is_aead, 0x009f);

« no previous file with comments | « net/ssl/ssl_cipher_suite_names.cc ('k') | no next file » | no next file with comments »