Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Side by Side Diff: net/ssl/ssl_cipher_suite_names_unittest.cc

Issue 1109283003: Change connection info strings (e.g. SHA-1 cert warnings) to be more clear. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Update unit test. Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « net/ssl/ssl_cipher_suite_names.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "net/ssl/ssl_cipher_suite_names.h" 5 #include "net/ssl/ssl_cipher_suite_names.h"
6 6
7 #include "base/basictypes.h" 7 #include "base/basictypes.h"
8 #include "testing/gtest/include/gtest/gtest.h" 8 #include "testing/gtest/include/gtest/gtest.h"
9 9
10 namespace net { 10 namespace net {
11 11
12 namespace { 12 namespace {
13 13
14 TEST(CipherSuiteNamesTest, Basic) { 14 TEST(CipherSuiteNamesTest, Basic) {
15 const char *key_exchange, *cipher, *mac; 15 const char *key_exchange, *cipher, *mac;
16 bool is_aead; 16 bool is_aead;
17 17
18 SSLCipherSuiteToStrings(&key_exchange, &cipher, &mac, &is_aead, 0xc001); 18 SSLCipherSuiteToStrings(&key_exchange, &cipher, &mac, &is_aead, 0xc001);
19 EXPECT_STREQ("ECDH_ECDSA", key_exchange); 19 EXPECT_STREQ("ECDH_ECDSA", key_exchange);
20 EXPECT_STREQ("NULL", cipher); 20 EXPECT_STREQ("NULL", cipher);
21 EXPECT_STREQ("SHA1", mac); 21 EXPECT_STREQ("HMAC-SHA1", mac);
22 EXPECT_FALSE(is_aead); 22 EXPECT_FALSE(is_aead);
23 23
24 SSLCipherSuiteToStrings(&key_exchange, &cipher, &mac, &is_aead, 0x009f); 24 SSLCipherSuiteToStrings(&key_exchange, &cipher, &mac, &is_aead, 0x009f);
25 EXPECT_STREQ("DHE_RSA", key_exchange); 25 EXPECT_STREQ("DHE_RSA", key_exchange);
26 EXPECT_STREQ("AES_256_GCM", cipher); 26 EXPECT_STREQ("AES_256_GCM", cipher);
27 EXPECT_TRUE(is_aead); 27 EXPECT_TRUE(is_aead);
28 EXPECT_EQ(NULL, mac); 28 EXPECT_EQ(NULL, mac);
29 29
30 SSLCipherSuiteToStrings(&key_exchange, &cipher, &mac, &is_aead, 0xcc15); 30 SSLCipherSuiteToStrings(&key_exchange, &cipher, &mac, &is_aead, 0xcc15);
31 EXPECT_STREQ("DHE_RSA", key_exchange); 31 EXPECT_STREQ("DHE_RSA", key_exchange);
(...skipping 43 matching lines...) Expand 10 before | Expand all | Expand 10 after
75 75
76 // Secure ones. 76 // Secure ones.
77 EXPECT_TRUE(IsSecureTLSCipherSuite(0xcc13)); 77 EXPECT_TRUE(IsSecureTLSCipherSuite(0xcc13));
78 EXPECT_TRUE(IsSecureTLSCipherSuite(0xcc14)); 78 EXPECT_TRUE(IsSecureTLSCipherSuite(0xcc14));
79 EXPECT_TRUE(IsSecureTLSCipherSuite(0xcc15)); 79 EXPECT_TRUE(IsSecureTLSCipherSuite(0xcc15));
80 } 80 }
81 81
82 } // anonymous namespace 82 } // anonymous namespace
83 83
84 } // namespace net 84 } // namespace net
OLDNEW
« no previous file with comments | « net/ssl/ssl_cipher_suite_names.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698