Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 1109283002: Remove stale Valgrind reference to mojo_application_manager_unittests. (Closed)

Created:
5 years, 7 months ago by msw
Modified:
5 years, 7 months ago
Reviewers:
Lei Zhang, sky
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, ben+mojo_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), glider+watch_chromium.org, bruening+watch_chromium.org, Ben Goodger (Google), sky, DaveMoore
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove stale Valgrind reference to mojo_application_manager_unittests. The target was removed in: https://codereview.chromium.org/1091513005 The tests are now part of mojo_shell_unittests. The valgrind bots don't seem to build or run this target... TODO: Make Valgrind build and run more mojo tests? BUG=416620 TEST=No valgrind failures. R=thestig@chromium.org Committed: https://crrev.com/d87d4ce9827c8ec138e611fa8595337d04883070 Cr-Commit-Position: refs/heads/master@{#327533}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
D tools/valgrind/gtest_exclude/mojo_application_manager_unittests.gtest-drmemory.txt View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
msw
Hey Lei, please take a look; thanks!
5 years, 7 months ago (2015-04-28 23:19:13 UTC) #1
sky
LGTM
5 years, 7 months ago (2015-04-28 23:23:00 UTC) #3
Lei Zhang
lgtm Can you file a bug for running mojo tests on chromium.memory and chromium.memory.fyi? Right ...
5 years, 7 months ago (2015-04-28 23:25:25 UTC) #5
msw
On 2015/04/28 23:25:25, Lei Zhang wrote: > lgtm > > Can you file a bug ...
5 years, 7 months ago (2015-04-29 18:27:33 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1109283002/1
5 years, 7 months ago (2015-04-29 18:28:06 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-04-29 18:50:44 UTC) #9
commit-bot: I haz the power
5 years, 7 months ago (2015-04-29 18:51:39 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d87d4ce9827c8ec138e611fa8595337d04883070
Cr-Commit-Position: refs/heads/master@{#327533}

Powered by Google App Engine
This is Rietveld 408576698