src/ic/ic.cc - Issue 1109223004: [strong] Disallow implicit conversions for add

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ic/ic.cc

Issue 1109223004: [strong] Disallow implicit conversions for add (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: cl feedback 3 Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/ic/ic.cc

diff --git a/src/ic/ic.cc b/src/ic/ic.cc

index 7e0fd2b62a26ead000a5d91bed53f0fbf2095412..69fe5f8b2ee527735f27ee5a7be96118cbf266c9 100644

--- a/src/ic/ic.cc

+++ b/src/ic/ic.cc

@@ -2821,7 +2821,7 @@ Builtins::JavaScript BinaryOpIC::TokenToJSBuiltin(Token::Value op,

if (is_strong(language_mode)) {

switch (op) {

default: UNREACHABLE();

- case Token::ADD: return Builtins::ADD;

+ case Token::ADD: return Builtins::ADD_STRONG;

case Token::SUB: return Builtins::SUB_STRONG;

case Token::MUL: return Builtins::MUL_STRONG;

case Token::DIV: return Builtins::DIV_STRONG;