Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Side by Side Diff: src/ic/ic.cc

Issue 1109223004: [strong] Disallow implicit conversions for add (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: cl feedback 3 Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #include "src/accessors.h" 7 #include "src/accessors.h"
8 #include "src/api.h" 8 #include "src/api.h"
9 #include "src/arguments.h" 9 #include "src/arguments.h"
10 #include "src/base/bits.h" 10 #include "src/base/bits.h"
(...skipping 2803 matching lines...) Expand 10 before | Expand all | Expand 10 after
2814 CHECK(false); 2814 CHECK(false);
2815 return isolate->heap()->undefined_value(); 2815 return isolate->heap()->undefined_value();
2816 } 2816 }
2817 2817
2818 2818
2819 Builtins::JavaScript BinaryOpIC::TokenToJSBuiltin(Token::Value op, 2819 Builtins::JavaScript BinaryOpIC::TokenToJSBuiltin(Token::Value op,
2820 LanguageMode language_mode) { 2820 LanguageMode language_mode) {
2821 if (is_strong(language_mode)) { 2821 if (is_strong(language_mode)) {
2822 switch (op) { 2822 switch (op) {
2823 default: UNREACHABLE(); 2823 default: UNREACHABLE();
2824 case Token::ADD: return Builtins::ADD; 2824 case Token::ADD: return Builtins::ADD_STRONG;
2825 case Token::SUB: return Builtins::SUB_STRONG; 2825 case Token::SUB: return Builtins::SUB_STRONG;
2826 case Token::MUL: return Builtins::MUL_STRONG; 2826 case Token::MUL: return Builtins::MUL_STRONG;
2827 case Token::DIV: return Builtins::DIV_STRONG; 2827 case Token::DIV: return Builtins::DIV_STRONG;
2828 case Token::MOD: return Builtins::MOD_STRONG; 2828 case Token::MOD: return Builtins::MOD_STRONG;
2829 case Token::BIT_OR: return Builtins::BIT_OR_STRONG; 2829 case Token::BIT_OR: return Builtins::BIT_OR_STRONG;
2830 case Token::BIT_AND: return Builtins::BIT_AND_STRONG; 2830 case Token::BIT_AND: return Builtins::BIT_AND_STRONG;
2831 case Token::BIT_XOR: return Builtins::BIT_XOR_STRONG; 2831 case Token::BIT_XOR: return Builtins::BIT_XOR_STRONG;
2832 case Token::SAR: return Builtins::SAR_STRONG; 2832 case Token::SAR: return Builtins::SAR_STRONG;
2833 case Token::SHR: return Builtins::SHR_STRONG; 2833 case Token::SHR: return Builtins::SHR_STRONG;
2834 case Token::SHL: return Builtins::SHL_STRONG; 2834 case Token::SHL: return Builtins::SHL_STRONG;
(...skipping 216 matching lines...) Expand 10 before | Expand all | Expand 10 after
3051 static const Address IC_utilities[] = { 3051 static const Address IC_utilities[] = {
3052 #define ADDR(name) FUNCTION_ADDR(name), 3052 #define ADDR(name) FUNCTION_ADDR(name),
3053 IC_UTIL_LIST(ADDR) NULL 3053 IC_UTIL_LIST(ADDR) NULL
3054 #undef ADDR 3054 #undef ADDR
3055 }; 3055 };
3056 3056
3057 3057
3058 Address IC::AddressFromUtilityId(IC::UtilityId id) { return IC_utilities[id]; } 3058 Address IC::AddressFromUtilityId(IC::UtilityId id) { return IC_utilities[id]; }
3059 } 3059 }
3060 } // namespace v8::internal 3060 } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/hydrogen.cc ('k') | src/runtime.js » ('j') | test/mjsunit/strong/implicit-conversions.js » ('J')

Powered by Google App Engine
This is Rietveld 408576698