Issue 11092076: SchemeIsSecure must return true for "wss"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11092076: SchemeIsSecure must return true for "wss" (Closed)

Created:
8 years, 2 months ago by Takashi Toyoshima

Modified:
8 years, 2 months ago

Reviewers:
brettw

CC:
chromium-reviews

Base URL:
http://git.chromium.org/external/google-url.git@master

Visibility:
Public.

More Reviews

Description

SchemeIsSecure must return true for "wss" BUG=http://crbug.com/155265

Patch Set 1 #

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	src/gurl.h	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Takashi Toyoshima

I Brett, I didn't find any real problems, but I happen to find this problem.

8 years, 2 months ago (2012-10-11 14:17:09 UTC) #1

brettw

8 years, 2 months ago (2012-10-12 19:50:44 UTC) #2

LGTM. I checked this in as googleurl@180. I did NOT pull deps. Please be sure to
pull deps very soon. You don't need to send a code review for this, but we
should do a try run before landing to make sure this doesn't break anything.

Expand Messages | Collapse Messages