Issue 11092058: Merge 161049 - [chromeos] Fix a use-after-free problem with LoginEventObserver

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11092058: Merge 161049 - [chromeos] Fix a use-after-free problem with LoginEventObserver (Closed)

Created:
8 years, 2 months ago by hshi1

Modified:
8 years, 2 months ago

Reviewers:
hshi

CC:
chromium-reviews, robertshield, kkania

Base URL:
svn://svn.chromium.org/chrome/branches/1271/src/

Visibility:
Public.

More Reviews

Description

Merge 161049 - [chromeos] Fix a use-after-free problem with LoginEventObserver Always use the static function ExistingUserController::current_controller() to obtain the pointer to the current user controller object. This is to prevent heap corruption when LoginEventObserver::Observe() is called after the controller is already freed. BUG=150568 TEST=tryserver Review URL: https://codereview.chromium.org/11088032 TBR=hshi@google.com Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=161188

Patch Set 1 #

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+11 lines, -14 lines)			Patch
M	chrome/browser/automation/automation_event_observers.h	View	3 chunks	+0 lines, -8 lines	0 comments	Download
M	chrome/browser/automation/automation_event_observers_chromeos.cc	View	2 chunks	+10 lines, -4 lines	0 comments	Download
M	chrome/browser/automation/testing_automation_provider_chromeos.cc	View	1 chunk	+1 line, -2 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages