Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issue 11088032: [chromeos] Fix a use-after-free problem with LoginEventObserver (Closed)

Created:
8 years, 2 months ago by hshi1
Modified:
8 years, 2 months ago
CC:
chromium-reviews, Aaron Boodman, James Su, mihaip-chromium-reviews_chromium.org, Nirnimesh, craigdh
Visibility:
Public.

Description

[chromeos] Fix a use-after-free problem with LoginEventObserver Always use the static function ExistingUserController::current_controller() to obtain the pointer to the current user controller object. This is to prevent heap corruption when LoginEventObserver::Observe() is called after the controller is already freed. BUG=150568 TEST=tryserver Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=161049

Patch Set 1 : Fixing heap-use-after-free problem. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -14 lines) Patch
M chrome/browser/automation/automation_event_observers.h View 3 chunks +0 lines, -8 lines 0 comments Download
M chrome/browser/automation/automation_event_observers_chromeos.cc View 2 chunks +10 lines, -4 lines 0 comments Download
M chrome/browser/automation/testing_automation_provider_chromeos.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
hshi1
Please take a look. This is to fix a subtle heap corruption problem introduced by ...
8 years, 2 months ago (2012-10-10 01:34:22 UTC) #1
hshi1
Add ben@ and darin@ as owners for review, and move Craig and Nirnimesh to CC. ...
8 years, 2 months ago (2012-10-10 02:24:58 UTC) #2
darin (slow to review)
OK, LGTM
8 years, 2 months ago (2012-10-10 04:57:35 UTC) #3
commit-bot: I haz the power
8 years, 2 months ago (2012-10-10 05:04:44 UTC) #4

Powered by Google App Engine
This is Rietveld 408576698