Chromium Code Reviews
Help | Chromium Project | Sign in
(274)

Issue 11092002: Add PRESUBMIT script to V8 (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 6 months ago by jochen (OOO until Apr 22)
Modified:
1 year, 3 months ago
Reviewers:
danno, ericgriffo66
CC:
v8-dev_googlegroups.com
Visibility:
Public.

Description

Add PRESUBMIT script to V8

Currently, it executes the OWNERS check and tools/presubmit.py, as well as a
check for a non-empty commit message

BUG=none
TEST=run git cl presubmit

Committed: https://code.google.com/p/v8/source/detail?r=12678

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -33 lines) Lint Patch
A + PRESUBMIT.py View 2 chunks +35 lines, -33 lines 0 comments ? errors Download
Trybot results:
Commit:

Messages

Total messages: 3
jochen (OOO until Apr 22)
plz review
1 year, 6 months ago #1
danno
lgtm, I'll land it for you
1 year, 6 months ago #2
ericgriffo66
1 year, 3 months ago #3
Message was sent while issue was closed.

          
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1280:2d3e6564b7b6