Chromium Code Reviews
Help | Chromium Project | Sign in
(11)

Issue 11092002: Add PRESUBMIT script to V8 (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years, 4 months ago by jochen (traveling)
Modified:
2 years, 1 month ago
Reviewers:
danno, ericgriffo66
CC:
v8-dev
Visibility:
Public.

Description

Add PRESUBMIT script to V8 Currently, it executes the OWNERS check and tools/presubmit.py, as well as a check for a non-empty commit message BUG=none TEST=run git cl presubmit Committed: https://code.google.com/p/v8/source/detail?r=12678

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -33 lines) Patch
A + PRESUBMIT.py View 2 chunks +35 lines, -33 lines 0 comments Download
Trybot results:
Commit:

Messages

Total messages: 3 (0 generated)
jochen (traveling)
plz review
2 years, 4 months ago (2012-10-08 13:25:50 UTC) #1
danno
lgtm, I'll land it for you
2 years, 4 months ago (2012-10-08 13:49:39 UTC) #2
ericgriffo66
2 years, 1 month ago (2013-01-04 05:14:25 UTC) #3
Message was sent while issue was closed.

          
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87e6a26