Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(336)

Issue 110913010: [Android] Fixes app crash when using both enable and disable delegated renderer command line switch. (Closed)

Created:
6 years, 12 months ago by vivekg_samsung
Modified:
6 years, 11 months ago
CC:
chromium-reviews, yusukes+watch_chromium.org, yukishiino+watch_chromium.org, jam, penghuang+watch_chromium.org, joi+watch-content_chromium.org, nona+watch_chromium.org, darin-cc_chromium.org, James Su, miu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

[Android] Fixes app crash when using both enable and disable delegated renderer command line switch. The function UsingDelegatedRenderer should also check for command line switch --disable-delegated-renderer's presence while determining the usage of delegated renderer. BUG=330714 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243428

Patch Set 1 #

Total comments: 1

Patch Set 2 : Patch for landing! #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -2 lines) Patch
M content/browser/renderer_host/render_widget_host_view_android.cc View 1 1 chunk +9 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
vivekg
Please take a look. Thank you.
6 years, 12 months ago (2013-12-26 17:06:50 UTC) #1
vivekg
On 2013/12/26 17:06:50, vivekg_ wrote: > Please take a look. Thank you. A gentle reminder!
6 years, 11 months ago (2014-01-06 01:01:14 UTC) #2
danakj
LGTM
6 years, 11 months ago (2014-01-06 20:49:39 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vivek.vg@samsung.com/110913010/1
6 years, 11 months ago (2014-01-06 23:18:10 UTC) #4
vivekg
On 2014/01/06 20:49:39, danakj wrote: > LGTM Thank you Dana. Wish you a happy new ...
6 years, 11 months ago (2014-01-06 23:33:13 UTC) #5
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=43439
6 years, 11 months ago (2014-01-06 23:38:44 UTC) #6
vivekg
@sievers or @aelias need an owner lgtm on this patch. Please take a look. Thank ...
6 years, 11 months ago (2014-01-07 19:36:21 UTC) #7
aelias_OOO_until_Jul13
lgtm modulo nit below https://codereview.chromium.org/110913010/diff/1/content/browser/renderer_host/render_widget_host_view_android.cc File content/browser/renderer_host/render_widget_host_view_android.cc (right): https://codereview.chromium.org/110913010/diff/1/content/browser/renderer_host/render_widget_host_view_android.cc#newcode101 content/browser/renderer_host/render_widget_host_view_android.cc:101: // TODO(vivekg): |using_delegated_renderer| should be ...
6 years, 11 months ago (2014-01-07 20:02:57 UTC) #8
vivekg
On 2014/01/07 20:02:57, aelias wrote: > lgtm modulo nit below > > https://codereview.chromium.org/110913010/diff/1/content/browser/renderer_host/render_widget_host_view_android.cc > File ...
6 years, 11 months ago (2014-01-07 20:12:36 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vivek.vg@samsung.com/110913010/200001
6 years, 11 months ago (2014-01-07 20:41:46 UTC) #10
commit-bot: I haz the power
6 years, 11 months ago (2014-01-07 23:27:18 UTC) #11
Message was sent while issue was closed.
Change committed as 243428

Powered by Google App Engine
This is Rietveld 408576698