Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(596)

Side by Side Diff: content/browser/renderer_host/render_widget_host_view_android.cc

Issue 110913010: [Android] Fixes app crash when using both enable and disable delegated renderer command line switch. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/browser/renderer_host/render_widget_host_view_android.h" 5 #include "content/browser/renderer_host/render_widget_host_view_android.h"
6 6
7 #include <android/bitmap.h> 7 #include <android/bitmap.h>
8 8
9 #include "base/basictypes.h" 9 #include "base/basictypes.h"
10 #include "base/bind.h" 10 #include "base/bind.h"
(...skipping 80 matching lines...) Expand 10 before | Expand all | Expand 10 after
91 scoped_ptr<cc::SingleReleaseCallback> release_callback, 91 scoped_ptr<cc::SingleReleaseCallback> release_callback,
92 scoped_ptr<SkBitmap> bitmap, 92 scoped_ptr<SkBitmap> bitmap,
93 scoped_ptr<SkAutoLockPixels> bitmap_pixels_lock, 93 scoped_ptr<SkAutoLockPixels> bitmap_pixels_lock,
94 bool result) { 94 bool result) {
95 bitmap_pixels_lock.reset(); 95 bitmap_pixels_lock.reset();
96 release_callback->Run(0, false); 96 release_callback->Run(0, false);
97 callback.Run(result, *bitmap); 97 callback.Run(result, *bitmap);
98 } 98 }
99 99
100 bool UsingDelegatedRenderer() { 100 bool UsingDelegatedRenderer() {
101 return CommandLine::ForCurrentProcess()->HasSwitch( 101 // TODO(vivekg): |using_delegated_renderer| should be set to "true"
aelias_OOO_until_Jul13 2014/01/07 20:02:57 Please remove this TODO. We usually add flags to
102 switches::kEnableDelegatedRenderer); 102 // once we enable delegated renderer as default on Android.
103 // crbug.com/208551
104 bool using_delegated_renderer = false;
105
106 using_delegated_renderer |= CommandLine::ForCurrentProcess()->HasSwitch(
107 switches::kEnableDelegatedRenderer);
108
109 using_delegated_renderer &= !CommandLine::ForCurrentProcess()->HasSwitch(
110 switches::kDisableDelegatedRenderer);
111
112 return using_delegated_renderer;
103 } 113 }
104 114
105 } // anonymous namespace 115 } // anonymous namespace
106 116
107 RenderWidgetHostViewAndroid::RenderWidgetHostViewAndroid( 117 RenderWidgetHostViewAndroid::RenderWidgetHostViewAndroid(
108 RenderWidgetHostImpl* widget_host, 118 RenderWidgetHostImpl* widget_host,
109 ContentViewCoreImpl* content_view_core) 119 ContentViewCoreImpl* content_view_core)
110 : host_(widget_host), 120 : host_(widget_host),
111 needs_begin_frame_(false), 121 needs_begin_frame_(false),
112 are_layers_attached_(!widget_host->is_hidden()), 122 are_layers_attached_(!widget_host->is_hidden()),
(...skipping 1294 matching lines...) Expand 10 before | Expand all | Expand 10 after
1407 // RenderWidgetHostView, public: 1417 // RenderWidgetHostView, public:
1408 1418
1409 // static 1419 // static
1410 RenderWidgetHostView* 1420 RenderWidgetHostView*
1411 RenderWidgetHostView::CreateViewForWidget(RenderWidgetHost* widget) { 1421 RenderWidgetHostView::CreateViewForWidget(RenderWidgetHost* widget) {
1412 RenderWidgetHostImpl* rwhi = RenderWidgetHostImpl::From(widget); 1422 RenderWidgetHostImpl* rwhi = RenderWidgetHostImpl::From(widget);
1413 return new RenderWidgetHostViewAndroid(rwhi, NULL); 1423 return new RenderWidgetHostViewAndroid(rwhi, NULL);
1414 } 1424 }
1415 1425
1416 } // namespace content 1426 } // namespace content
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698