Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Issue 1109033002: dart2js: Do not emit closure classes if their instantiation is dead code. (Closed)

Created:
5 years, 8 months ago by herhut
Modified:
5 years, 7 months ago
Reviewers:
floitsch
CC:
reviews_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

dart2js: Do not emit closure classes if their instantiation is dead code. BUG= R=floitsch@google.com Committed: https://code.google.com/p/dart/source/detail?r=45454

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M pkg/compiler/lib/src/ssa/builder.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/ssa/codegen.dart View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
herhut
5 years, 8 months ago (2015-04-28 00:57:20 UTC) #2
floitsch
LGTM.
5 years, 8 months ago (2015-04-28 04:24:07 UTC) #3
herhut
5 years, 7 months ago (2015-04-29 19:19:43 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:20001) manually as 45454 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698