pkg/compiler/lib/src/ssa/builder.dart - Issue 1109033002: dart2js: Do not emit closure classes if their instantiation is dead code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/compiler/lib/src/ssa/builder.dart

Issue 1109033002: dart2js: Do not emit closure classes if their instantiation is dead code. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: pkg/compiler/lib/src/ssa/builder.dart

diff --git a/pkg/compiler/lib/src/ssa/builder.dart b/pkg/compiler/lib/src/ssa/builder.dart

index b2b0dd7fbfe8da23ba0a8f63229472ed6b362946..7f5b23c9c5bcaa3bf6fe3c199bf02dd731afed6b 100644

--- a/pkg/compiler/lib/src/ssa/builder.dart

+++ b/pkg/compiler/lib/src/ssa/builder.dart

@@ -3055,8 +3055,6 @@ class SsaBuilder extends NewResolvedVisitor {

// TODO(johnniwinther): Is [registerStaticUse] equivalent to

// [addToWorkList]?

registry.registerStaticUse(callElement);

- // TODO(ahe): This should be registered in codegen, not here.

- registry.registerInstantiatedClass(closureClassElement);

List<HInstruction> capturedVariables = <HInstruction>[];

closureClassElement.closureFields.forEach((ClosureFieldElement field) {

« no previous file with comments | « no previous file | pkg/compiler/lib/src/ssa/codegen.dart » ('j') | no next file with comments »