Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issue 1109013002: [Sync] Ensure isSyncable is set when signed in. (Closed)

Created:
5 years, 7 months ago by (dont use) zea at google
Modified:
5 years, 7 months ago
Reviewers:
maxbogue
CC:
chromium-reviews, tim+watch_chromium.org, zea+watch_chromium.org, maxbogue+watch_chromium.org, pvalenzuela+watch_chromium.org, plaree+watch_chromium.org, maniscalco+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@2357
Target Ref:
refs/pending/branch-heads/2357
Project:
chromium
Visibility:
Public.

Description

[Sync] Ensure isSyncable is set when signed in. This is a more extensive version of http://crrev.com/1075343003 for landing on trunk. Previously, if isSyncable is false, but sync is enabled for Chrome, even if you sign in, Chrome would never set syncable to true. This CL ensures that syncable is always set to true if there is an account signed in, regardless of whether chrome sync is enabled or not. Additionally, it sets syncable to false when no account is signed in, to ensure that the user does not see a non-functional switch in the Android settings. The new AccountManager setup in the test is necessary so that the test accounts can be cleaned up by the loop in updateSyncability(). BUG=475299 TEST=Regression tests added, plus: Ensure that $ adb shell dumpsys content | grep chrome should show syncable=0 and enabled=true Sign in to Chrome. Now dumpsys should say syncable=1 and enabled=true. Review URL: https://codereview.chromium.org/1062973004 Note: this commit replaces 3d3e24b64e733b480b97352165b5cecd3b9ed145 (https://codereview.chromium.org/1075343003) TBR=maxbogue@chromium.org Cr-Commit-Position: refs/heads/master@{#326122} (cherry picked from commit fd45731d49e2274221be3df2bd2fb3c8b0bed613) Committed: https://chromium.googlesource.com/chromium/src/+/63fbaf9c76aa64eeae686ff88ec34ced52203bfe

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -14 lines) Patch
M sync/android/java/src/org/chromium/sync/AndroidSyncSettings.java View 3 chunks +12 lines, -8 lines 0 comments Download
M sync/android/javatests/src/org/chromium/sync/AndroidSyncSettingsTest.java View 4 chunks +31 lines, -2 lines 0 comments Download
M sync/test/android/javatests/src/org/chromium/sync/test/util/MockSyncContentResolverDelegate.java View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
(dont use) zea at google
5 years, 7 months ago (2015-04-28 00:27:50 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
63fbaf9c76aa64eeae686ff88ec34ced52203bfe (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698