Issue 1075343003: Ensure that isSyncable is set when Chrome sync is enabled.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1075343003: Ensure that isSyncable is set when Chrome sync is enabled. (Closed)

Created:
5 years, 8 months ago by nyquist

Modified:
5 years, 8 months ago

Reviewers:

CC:
chromium-reviews, tim+watch_chromium.org, zea+watch_chromium.org, maxbogue+watch_chromium.org, pvalenzuela+watch_chromium.org, plaree+watch_chromium.org, maniscalco+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@2357

Target Ref:
refs/pending/branch-heads/2357

Project:
chromium

Visibility:
Public.

More Reviews

Description

Ensure that isSyncable is set when Chrome sync is enabled. If isSyncable is false, but sync is enabled for Chrome, even if you sign in, Chrome never sets syncable to true. This CL ensures that syncable is always set to true if there is an account signed in, regardless of whether chrome sync is enabled or not. BUG=475299 TEST=Regression test added, plus: Ensure that $ adb shell dumpsys content should show syncable=0 and enabled=true Sign in to Chrome. Now dumpsys should say syncable=1 and enabled=true.

Patch Set 1 #

Created: 5 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+28 lines, -2 lines)			Patch
M	sync/android/java/src/org/chromium/sync/AndroidSyncSettings.java	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	sync/android/javatests/src/org/chromium/sync/AndroidSyncSettingsTest.java	View	1 chunk	+25 lines, -0 lines	0 comments	Download
M	sync/test/android/javatests/src/org/chromium/sync/test/util/MockSyncContentResolverDelegate.java	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

nyquist

5 years, 8 months ago (2015-04-17 23:20:39 UTC) #2

Full link:
https://chromium.googlesource.com/chromium/src/+/3d3e24b64e733b480b97352165b5...

Expand Messages | Collapse Messages