Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 11090031: Merge 160443 - [Mac] During shutdown, do not post NSApplicationWillTerminateNotification twice. (Closed)

Created:
8 years, 2 months ago by Robert Sesek
Modified:
8 years, 2 months ago
Reviewers:
Robert Sesek
CC:
chromium-reviews
Visibility:
Public.

Description

Merge 160443 - [Mac] During shutdown, do not post NSApplicationWillTerminateNotification twice. In the quit path where zero browser windows are open, -[BrowserCrApplication terminate:] was posting NSApplicationWillTerminateNotification twice, via the stacks pasted on the bug. Some system code assumes that after posting this notification, _exit() will be called and so it does not bother removing itself as an observer, which leads to a shutdown crash. This change makes it so that browser::HandleAppExitingForPlatform() is responsible for posting the notification. That function is called via browser::OnAppExiting(), which is the final step in the cross-platform shutdown code. At that time, all browsers have been closed and shutdown cannot be aborted, so this should only ever be called once. BUG=153283 TEST=Prayer and a sacrificial goat. Review URL: https://codereview.chromium.org/11066035 TBR=rsesek@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=160936

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -8 lines) Patch
M chrome/browser/chrome_browser_application_mac.mm View 1 chunk +7 lines, -6 lines 0 comments Download
M chrome/browser/lifetime/application_lifetime_mac.mm View 1 chunk +29 lines, -2 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
Robert Sesek
8 years, 2 months ago (2012-10-09 21:44:49 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698