[Mac] During shutdown, do not post NSApplicationWillTerminateNotification twice.

[Mac] During shutdown, do not post NSApplicationWillTerminateNotification twice.

In the quit path where zero browser windows are open,
-[BrowserCrApplication terminate:] was posting
NSApplicationWillTerminateNotification twice, via the stacks pasted on the bug.
Some system code assumes that after posting this notification, _exit() will be
called and so it does not bother removing itself as an observer, which leads
to a shutdown crash.

This change makes it so that browser::HandleAppExitingForPlatform() is
responsible for posting the notification. That function is called via
browser::OnAppExiting(), which is the final step in the cross-platform shutdown
code. At that time, all browsers have been closed and shutdown cannot be aborted,
so this should only ever be called once.

BUG=153283
TEST=Prayer and a sacrificial goat.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=160443

[Robert Sesek, 2012-10-05 01:12:37]

mark/trung: review
shess: see if you can actually get trung to review, or just review yourself

I don't think this CL is too scary…

[Mark Mentovai, 2012-10-05 18:14:53]

LGTM

[Scott Hess - ex-Googler, 2012-10-05 19:04:41]

Hellifiknow.

https://codereview.chromium.org/11066035/diff/1/chrome/browser/lifetime/appli...
File chrome/browser/lifetime/application_lifetime_mac.mm (right):

https://codereview.chromium.org/11066035/diff/1/chrome/browser/lifetime/appli...
chrome/browser/lifetime/application_lifetime_mac.mm:35: void
HandleAppExitingForPlatform() {
  static bool kill_me_now = false;
  CHECK(!kill_me_now);
  kill_me_now = true;

[Robert Sesek, 2012-10-05 19:10:43]

https://codereview.chromium.org/11066035/diff/1/chrome/browser/lifetime/appli...
File chrome/browser/lifetime/application_lifetime_mac.mm (right):

https://codereview.chromium.org/11066035/diff/1/chrome/browser/lifetime/appli...
chrome/browser/lifetime/application_lifetime_mac.mm:35: void
HandleAppExitingForPlatform() {
On 2012/10/05 19:04:41, shess wrote:
>   static bool kill_me_now = false;
>   CHECK(!kill_me_now);
>   kill_me_now = true;

Done.

[Scott Hess - ex-Googler, 2012-10-05 19:13:19]

Well, you still aren't going to get a LGTM from me on this, unless you resort to
underhanded trickery.

[commit-bot: I haz the power, 2012-10-05 19:15:46]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rsesek@chromium.org/11066035/4

[commit-bot: I haz the power, 2012-10-05 19:15:48]

Presubmit check for 11066035-4 failed and returned exit status 1.


Running presubmit commit checks ...

** Presubmit ERRORS **
Missing LGTM from an OWNER for files in these directories:
    chrome

Was the presubmit check useful? Please send feedback & hate mail to
maruel@chromium.org!

[Robert Sesek, 2012-10-05 19:15:49]

On 2012/10/05 19:13:19, shess wrote:
> Well, you still aren't going to get a LGTM from me on this, unless you resort
to
> underhanded trickery.

I'll count yours as a 0.5.