Chromium Code Reviews| Index: pkg/dartdoc/lib/dartdoc.dart |
| =================================================================== |
| --- pkg/dartdoc/lib/dartdoc.dart (revision 13588) |
| +++ pkg/dartdoc/lib/dartdoc.dart (working copy) |
| @@ -1205,7 +1205,7 @@ |
| * is `true` (and [includeSource] is set), also includes the source code. |
| */ |
| void docCode(ObjectMirror host, Location location, DocComment comment, |
| - [bool showCode = false]) { |
| + {bool showCode: false}) { |
| writeln('<div class="doc">'); |
| if (comment != null) { |
| if (comment.inheritedFrom !== null) { |
| @@ -1427,7 +1427,7 @@ |
| } |
| /** Generates a human-friendly string representation for a type. */ |
| - typeName(TypeMirror type, [bool showBounds = false]) { |
| + typeName(TypeMirror type, {bool showBounds: false}) { |
| if (type.isVoid) { |
| return 'void'; |
| } |
| @@ -1498,9 +1498,9 @@ |
| * style it appropriately. |
| */ |
| md.Node resolveNameReference(String name, |
| - [MemberMirror currentMember = null, |
| - ObjectMirror currentType = null, |
| - LibraryMirror currentLibrary = null]) { |
| + {MemberMirror currentMember: null, |
|
Jennifer Messerly
2012/10/12 02:35:58
do we need the null here?
Lasse Reichstein Nielsen
2012/10/12 07:52:19
No (and we didn't before either).
I'm usually all
regis
2012/10/12 17:51:51
Lasse is correct, nulls are redundant. This cl doe
|
| + ObjectMirror currentType: null, |
| + LibraryMirror currentLibrary: null}) { |
| makeLink(String href) { |
| final anchor = new md.Element.text('a', name); |
| anchor.attributes['href'] = relativePath(href); |