Change core lib, dart2js, and more for new optional parameters syntax

pkg/dartdoc/lib/dartdoc.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 /**
  * To generate docs for a library, run this script with the path to an
  * entrypoint .dart file, like:
  *
  *     $ dart dartdoc.dart foo.dart
  *
@@ skipping 1187 matching lines @@
 
     if (inOptionals) write(']');
     write(')');
   }
 
   /**
    * Documents the code contained within [span] with [comment]. If [showCode]
    * is `true` (and [includeSource] is set), also includes the source code.
    */
   void docCode(ObjectMirror host, Location location, DocComment comment,
-               [bool showCode = false]) {
+               {bool showCode: false}) {
     writeln('<div class="doc">');
     if (comment != null) {
       if (comment.inheritedFrom !== null) {
         writeln('<div class="inherited">');
         writeln(comment.html);
         write('<div class="docs-inherited-from">docs inherited from ');
         annotateType(host, comment.inheritedFrom);
         write('</div>');
         writeln('</div>');
       } else {
@@ skipping 201 matching lines @@
   }
 
   /** Creates a linked cross reference to [type]. */
   typeReference(InterfaceMirror type) {
     // TODO(rnystrom): Do we need to handle ParameterTypes here like
     // annotation() does?
     return a(typeUrl(type), typeName(type), css: 'crossref');
   }
 
   /** Generates a human-friendly string representation for a type. */
-  typeName(TypeMirror type, [bool showBounds = false]) {
+  typeName(TypeMirror type, {bool showBounds: false}) {
     if (type.isVoid) {
       return 'void';
     }
     if (type is TypeVariableMirror) {
       return type.simpleName;
     }
     assert(type is InterfaceMirror);
 
     // See if it's a generic type.
     if (type.isDeclaration) {
@@ skipping 50 matching lines @@
     // Syntax highlight.
     return classifySource(code);
   }
 
   /**
    * This will be called whenever a doc comment hits a `[name]` in square
    * brackets. It will try to figure out what the name refers to and link or
    * style it appropriately.
    */
   md.Node resolveNameReference(String name,
-                               [MemberMirror currentMember = null,
-                                ObjectMirror currentType = null,
-                                LibraryMirror currentLibrary = null]) {
+                               {MemberMirror currentMember: null,

[Jennifer Messerly, 2012/10/12 02:35:58]

do we need the null here?

[Lasse Reichstein Nielsen, 2012/10/12 07:52:19]

No (and we didn't before either).
I'm usually all for giving redundant information if it improves readability, but
here I'd omit the nulls too.

[regis, 2012/10/12 17:51:51]

Lasse is correct, nulls are redundant. This cl does not try to address stylistic
issues, but since you explicitly point to these, I removed the nulls here. There
are many other instances of redundant nulls, though.   

+                                ObjectMirror currentType: null,
+                                LibraryMirror currentLibrary: null}) {
     makeLink(String href) {
       final anchor = new md.Element.text('a', name);
       anchor.attributes['href'] = relativePath(href);
       anchor.attributes['class'] = 'crossref';
       return anchor;
     }
 
     // See if it's a parameter of the current method.
     if (currentMember is MethodMirror) {
       for (final parameter in currentMember.parameters) {
@@ skipping 125 matching lines @@
   final InterfaceMirror inheritedFrom;
 
   DocComment(this.text, [this.inheritedFrom = null]) {
     assert(text != null && !text.trim().isEmpty());
   }
 
   String get html => md.markdownToHtml(text);
 
   String toString() => text;
 }