Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Issue 1108993004: Move user_story.shared_user_story_state to story.shared_state (Closed)

Created:
5 years, 7 months ago by aiolos (Not reviewing)
Modified:
5 years, 7 months ago
Reviewers:
nednguyen, dtu, sullivan
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@rename_user_story
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move user_story.shared_user_story_state to story.shared_state BUG=465594 Committed: https://crrev.com/6d62551b30fb6cf12a2a50c1ab4feb08c386a2ba Cr-Commit-Position: refs/heads/master@{#327596}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+80 lines, -143 lines) Patch
M tools/telemetry/telemetry/benchmark_unittest.py View 2 chunks +4 lines, -4 lines 0 comments Download
M tools/telemetry/telemetry/page/shared_page_state.py View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/telemetry/telemetry/page/shared_page_state_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/results/user_story_run_unittest.py View 2 chunks +3 lines, -3 lines 0 comments Download
A + tools/telemetry/telemetry/story/shared_state.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/unittest_util/page_set_smoke_test.py View 1 chunk +6 lines, -6 lines 0 comments Download
M tools/telemetry/telemetry/user_story/__init__.py View 5 chunks +10 lines, -10 lines 0 comments Download
M tools/telemetry/telemetry/user_story/android/__init__.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/user_story/android/shared_app_state.py View 1 chunk +2 lines, -2 lines 0 comments Download
D tools/telemetry/telemetry/user_story/shared_user_story_state.py View 1 chunk +0 lines, -63 lines 0 comments Download
M tools/telemetry/telemetry/user_story/user_story_runner.py View 3 chunks +17 lines, -17 lines 0 comments Download
M tools/telemetry/telemetry/user_story/user_story_runner_unittest.py View 12 chunks +18 lines, -18 lines 0 comments Download
M tools/telemetry/telemetry/user_story/user_story_set.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/telemetry/telemetry/user_story/user_story_set_unittest.py View 1 chunk +3 lines, -3 lines 0 comments Download
M tools/telemetry/telemetry/user_story/user_story_unittest.py View 2 chunks +10 lines, -10 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
aiolos (Not reviewing)
Per discussion with Ned offline, I'm not providing a stub for the old shared_user_story_state. I ...
5 years, 7 months ago (2015-04-29 20:54:00 UTC) #3
nednguyen
lgtm
5 years, 7 months ago (2015-04-29 20:57:06 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1108993004/1
5 years, 7 months ago (2015-04-29 21:54:20 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-04-29 22:07:02 UTC) #7
commit-bot: I haz the power
5 years, 7 months ago (2015-04-29 22:07:52 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6d62551b30fb6cf12a2a50c1ab4feb08c386a2ba
Cr-Commit-Position: refs/heads/master@{#327596}

Powered by Google App Engine
This is Rietveld 408576698