tools/telemetry/telemetry/unittest_util/page_set_smoke_test.py - Issue 1108993004: Move user_story.shared_user_story_state to story.shared_state

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/unittest_util/page_set_smoke_test.py

Issue 1108993004: Move user_story.shared_user_story_state to story.shared_state (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@rename_user_story

Patch Set: Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/telemetry/telemetry/unittest_util/page_set_smoke_test.py

diff --git a/tools/telemetry/telemetry/unittest_util/page_set_smoke_test.py b/tools/telemetry/telemetry/unittest_util/page_set_smoke_test.py

index cc04346e764191b026d8edfd961103b81e8a66b1..bc432daf7e629982675327aed17baf126f793ae9 100644

--- a/tools/telemetry/telemetry/unittest_util/page_set_smoke_test.py

+++ b/tools/telemetry/telemetry/unittest_util/page_set_smoke_test.py

@@ -114,14 +114,14 @@ class PageSetSmokeTest(unittest.TestCase):

def CheckSharedStates(self, page_set):

if not page_set.allow_mixed_story_states:

- shared_user_story_state_class = (

- page_set.user_stories[0].shared_user_story_state_class)

+ shared_state_class = (

+ page_set.user_stories[0].shared_state_class)

for p in page_set:

self.assertIs(

- shared_user_story_state_class,

- p.shared_user_story_state_class,

- msg='page %s\'s shared_user_story_state_class field is different '

- 'from other pages\'s shared_user_story_state_class whereas '

+ shared_state_class,

+ p.shared_state_class,

+ msg='page %s\'s shared_state_class field is different '

+ 'from other pages\'s shared_state_class whereas '

'page set %s disallow having mixed states' %

(p, page_set))

« no previous file with comments | « tools/telemetry/telemetry/story/shared_state.py ('k') | tools/telemetry/telemetry/user_story/__init__.py » ('j') | no next file with comments »