Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(405)

Issue 1108973004: Update ax_provider_unittest.cc for new BlinkPlatformImpl ctor. (Closed)

Created:
5 years, 7 months ago by msw
Modified:
5 years, 7 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update ax_provider_unittest.cc for new BlinkPlatformImpl ctor. Build break: http://build.chromium.org/p/chromium.mojo/builders/Chromium%20Mojo%20Linux/builds/5072 Relevant CL: https://codereview.chromium.org/1112573003 BUG=NONE TEST=Building components/html_viewer:tests passes. R=sky@chromium.org TBR=jochen@chromium.org NOTRY=true Committed: https://chromium.googlesource.com/chromium/src/+/019a57a8f6f38eee54a7a255829e810d4b70b59b

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M components/html_viewer/ax_provider_impl_unittest.cc View 1 2 chunks +6 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
msw
Hey Jochen and Scott, please take a look; thanks!
5 years, 7 months ago (2015-04-28 20:38:13 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1108973004/1
5 years, 7 months ago (2015-04-28 20:38:29 UTC) #3
sky
LGTM https://codereview.chromium.org/1108973004/diff/1/components/html_viewer/ax_provider_impl_unittest.cc File components/html_viewer/ax_provider_impl_unittest.cc (right): https://codereview.chromium.org/1108973004/diff/1/components/html_viewer/ax_provider_impl_unittest.cc#newcode53 components/html_viewer/ax_provider_impl_unittest.cc:53: renderer_scheduler_ = scheduler::RendererScheduler::Create(); Can you move this to ...
5 years, 7 months ago (2015-04-28 21:25:06 UTC) #4
msw
https://codereview.chromium.org/1108973004/diff/1/components/html_viewer/ax_provider_impl_unittest.cc File components/html_viewer/ax_provider_impl_unittest.cc (right): https://codereview.chromium.org/1108973004/diff/1/components/html_viewer/ax_provider_impl_unittest.cc#newcode53 components/html_viewer/ax_provider_impl_unittest.cc:53: renderer_scheduler_ = scheduler::RendererScheduler::Create(); On 2015/04/28 21:25:06, sky wrote: > ...
5 years, 7 months ago (2015-04-28 21:30:26 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1108973004/20001
5 years, 7 months ago (2015-04-28 21:33:12 UTC) #8
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/019a57a8f6f38eee54a7a255829e810d4b70b59b Cr-Commit-Position: refs/heads/master@{#327370}
5 years, 7 months ago (2015-04-28 21:57:49 UTC) #9
msw
5 years, 7 months ago (2015-04-28 21:58:08 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
019a57a8f6f38eee54a7a255829e810d4b70b59b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698