Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issue 1112573003: Hook up the scheduler component to html_viewer (Closed)

Created:
5 years, 7 months ago by jochen (gone - plz use gerrit)
Modified:
5 years, 7 months ago
Reviewers:
sky, Sami
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Hook up the scheduler component to html_viewer BUG=477690 R=skyostil@chromium.org,sky@chromium.org Committed: https://crrev.com/83d116dead0e621c20b530cfca1d3a50acd84262 Cr-Commit-Position: refs/heads/master@{#327352}

Patch Set 1 #

Total comments: 1

Patch Set 2 : updates #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -420 lines) Patch
M components/html_viewer/BUILD.gn View 2 chunks +1 line, -4 lines 0 comments Download
M components/html_viewer/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M components/html_viewer/blink_platform_impl.h View 1 6 chunks +10 lines, -4 lines 0 comments Download
M components/html_viewer/blink_platform_impl.cc View 1 6 chunks +24 lines, -29 lines 0 comments Download
M components/html_viewer/html_viewer.cc View 3 chunks +5 lines, -1 line 0 comments Download
D components/html_viewer/web_scheduler_impl.h View 1 chunk +0 lines, -40 lines 0 comments Download
D components/html_viewer/web_scheduler_impl.cc View 1 chunk +0 lines, -67 lines 0 comments Download
D components/html_viewer/web_thread_impl.h View 1 chunk +0 lines, -88 lines 0 comments Download
D components/html_viewer/web_thread_impl.cc View 1 chunk +0 lines, -187 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
jochen (gone - plz use gerrit)
5 years, 7 months ago (2015-04-28 14:45:49 UTC) #1
Sami
lgtm with a nit. Is there a plan to somehow unify the duplicated BlinkPlatformImpls between ...
5 years, 7 months ago (2015-04-28 15:20:21 UTC) #2
sky
LGTM
5 years, 7 months ago (2015-04-28 16:54:04 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1112573003/20001
5 years, 7 months ago (2015-04-28 18:48:34 UTC) #6
jochen (gone - plz use gerrit)
yeah, that's what moving stuff like the scheduler to a component is about, so eventually, ...
5 years, 7 months ago (2015-04-28 18:50:05 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-04-28 19:56:39 UTC) #8
commit-bot: I haz the power
5 years, 7 months ago (2015-04-28 19:57:45 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/83d116dead0e621c20b530cfca1d3a50acd84262
Cr-Commit-Position: refs/heads/master@{#327352}

Powered by Google App Engine
This is Rietveld 408576698