mac: Only use the flag -gline-tables-only for release builds.

mac: Only use the flag -gline-tables-only for release builds.

Previously, the flag was being used for both debug and release builds.

BUG=480622
Committed: https://crrev.com/df3b7ba64eddf6681c521a411691cd330fc2b434
Cr-Commit-Position: refs/heads/master@{#327193}

[erikchen, 2015-04-27 22:02:49]

erikchen@chromium.org changed reviewers:
+ thakis@chromium.org

[erikchen, 2015-04-27 22:02:49]

thakis: This failed to apply "-gline-tables-only" to my local static, Release
build of Official Google Chrome. Any idea why?

GYP flags:
export GYP_GENERATORS="ninja,xcode-ninja"
export GYP_DEFINES="$GYP_DEFINES dcheck_always_on=1"                            
export GYP_DEFINES="$GYP_DEFINES branding=Chrome buildtype=Official"            
export GYP_DEFINES="$GYP_DEFINES target_arch=x64"                               
export GYP_DEFINES="$GYP_DEFINES mac_sdk_min=10.10"    
export GYP_GENERATOR_FLAGS="output_dir=out_static"


Ninja command:
ninja -C out_static/Release chrome

[Nico, 2015-04-27 22:14:17]

https://codereview.chromium.org/1108933002/diff/1/build/common.gypi
File build/common.gypi (right):

https://codereview.chromium.org/1108933002/diff/1/build/common.gypi#newcode5141
build/common.gypi:5141: 'configurations': {
I'm guessing configurations needs to be a top-level thing. In your CL it's
nested inside xcode_settings. Try moving it next to that?

[erikchen, 2015-04-27 23:26:19]

thakis: PTAL

https://codereview.chromium.org/1108933002/diff/1/build/common.gypi
File build/common.gypi (right):

https://codereview.chromium.org/1108933002/diff/1/build/common.gypi#newcode5141
build/common.gypi:5141: 'configurations': {
On 2015/04/27 22:14:17, Nico wrote:
> I'm guessing configurations needs to be a top-level thing. In your CL it's
> nested inside xcode_settings. Try moving it next to that?

You're right.

[Nico, 2015-04-27 23:27:21]

lgtm

[erikchen, 2015-04-27 23:27:46]

The CQ bit was checked by erikchen@chromium.org

[commit-bot: I haz the power, 2015-04-27 23:28:09]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1108933002/20001

[commit-bot: I haz the power, 2015-04-28 00:30:32]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-04-28 00:32:20]

Patchset 2 (id:??) landed as
https://crrev.com/df3b7ba64eddf6681c521a411691cd330fc2b434
Cr-Commit-Position: refs/heads/master@{#327193}