Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Side by Side Diff: build/common.gypi

Issue 1108933002: mac: Only use the flag -gline-tables-only for release builds. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 # IMPORTANT: 5 # IMPORTANT:
6 # Please don't directly include this file if you are building via gyp_chromium, 6 # Please don't directly include this file if you are building via gyp_chromium,
7 # since gyp_chromium is automatically forcing its inclusion. 7 # since gyp_chromium is automatically forcing its inclusion.
8 { 8 {
9 # Variables expected to be overriden on the GYP command line (-D) or by 9 # Variables expected to be overriden on the GYP command line (-D) or by
10 # ~/.gyp/include.gypi. 10 # ~/.gyp/include.gypi.
(...skipping 5120 matching lines...) Expand 10 before | Expand all | Expand 10 after
5131 # xcode_setting, but not until all downstream projects' mac bots are 5131 # xcode_setting, but not until all downstream projects' mac bots are
5132 # using xcode >= 4.6, because that's when the default value of the 5132 # using xcode >= 4.6, because that's when the default value of the
5133 # flag in the compiler switched. Pre-4.6, the value 'NO' for that 5133 # flag in the compiler switched. Pre-4.6, the value 'NO' for that
5134 # setting is a no-op as far as xcode is concerned, but the compiler 5134 # setting is a no-op as far as xcode is concerned, but the compiler
5135 # behaves differently based on whether -fno-strict-aliasing is 5135 # behaves differently based on whether -fno-strict-aliasing is
5136 # specified or not. 5136 # specified or not.
5137 '-fno-strict-aliasing', # See http://crbug.com/32204. 5137 '-fno-strict-aliasing', # See http://crbug.com/32204.
5138 ], 5138 ],
5139 'conditions': [ 5139 'conditions': [
5140 ['branding=="Chrome" and buildtype=="Official"', { 5140 ['branding=="Chrome" and buildtype=="Official"', {
5141 'OTHER_CFLAGS': [ 5141 'configurations': {
Nico 2015/04/27 22:14:17 I'm guessing configurations needs to be a top-leve
erikchen 2015/04/27 23:26:19 You're right.
5142 # The Google Chrome Framework dSYM generated by dsymutil has 5142 'Release_Base': {
5143 # grown larger than 4GB, which dsymutil can't handle. Reduce 5143 'OTHER_CFLAGS': [
5144 # the amount of debug symbols. 5144 # The Google Chrome Framework dSYM generated by dsymutil has
5145 '-gline-tables-only', # See http://crbug.com/479841 5145 # grown larger than 4GB, which dsymutil can't handle. Reduce
5146 ] 5146 # the amount of debug symbols.
5147 '-gline-tables-only', # See http://crbug.com/479841
5148 ]
5149 }, # configuration "Release"
5150 }, # configurations
5147 }], 5151 }],
5148 ], 5152 ],
5149 }, 5153 },
5150 'target_conditions': [ 5154 'target_conditions': [
5151 ['_type=="executable"', { 5155 ['_type=="executable"', {
5152 'postbuilds': [ 5156 'postbuilds': [
5153 { 5157 {
5154 # Arranges for data (heap) pages to be protected against 5158 # Arranges for data (heap) pages to be protected against
5155 # code execution when running on Mac OS X 10.7 ("Lion"), and 5159 # code execution when running on Mac OS X 10.7 ("Lion"), and
5156 # ensures that the position-independent executable (PIE) bit 5160 # ensures that the position-independent executable (PIE) bit
(...skipping 999 matching lines...) Expand 10 before | Expand all | Expand 10 after
6156 # settings in target dicts. SYMROOT is a special case, because many other 6160 # settings in target dicts. SYMROOT is a special case, because many other
6157 # Xcode variables depend on it, including variables such as 6161 # Xcode variables depend on it, including variables such as
6158 # PROJECT_DERIVED_FILE_DIR. When a source group corresponding to something 6162 # PROJECT_DERIVED_FILE_DIR. When a source group corresponding to something
6159 # like PROJECT_DERIVED_FILE_DIR is added to a project, in order for the 6163 # like PROJECT_DERIVED_FILE_DIR is added to a project, in order for the
6160 # files to appear (when present) in the UI as actual files and not red 6164 # files to appear (when present) in the UI as actual files and not red
6161 # red "missing file" proxies, the correct path to PROJECT_DERIVED_FILE_DIR, 6165 # red "missing file" proxies, the correct path to PROJECT_DERIVED_FILE_DIR,
6162 # and therefore SYMROOT, needs to be set at the project level. 6166 # and therefore SYMROOT, needs to be set at the project level.
6163 'SYMROOT': '<(DEPTH)/xcodebuild', 6167 'SYMROOT': '<(DEPTH)/xcodebuild',
6164 }, 6168 },
6165 } 6169 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698