Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(432)

Issue 1108893003: Revert of Move ScopedFileDescriptor to dbus/file_descriptor.h (Closed)

Created:
5 years, 7 months ago by spang
Modified:
5 years, 7 months ago
CC:
chromium-reviews, stevenjb+watch_chromium.org, oshima+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Move ScopedFileDescriptor to dbus/file_descriptor.h (patchset #1 id:1 of https://codereview.chromium.org/1090243003/) Reason for revert: Breaks shared_library build with broken exports: ./../dbus/dbus_export.h:20:65: error: ignoring attributes applied to class type 'scoped_ptr<dbus::FileDescriptor, dbus::FileDescriptor::Deleter>' outside of definition [-Werror=attributes] #define CHROME_DBUS_EXPORT __attribute__((visibility("default"))) ^ ../../dbus/file_descriptor.h:81:57: note: in expansion of macro 'CHROME_DBUS_EXPORT' scoped_ptr<FileDescriptor, FileDescriptor::Deleter> CHROME_DBUS_EXPORT; Original issue's description: > Move ScopedFileDescriptor to dbus/file_descriptor.h > > ScopedFileDescriptor was initially introduced to facilitate the > management of a 'lifeline' FD used when asking permission_broker to > open a port in the device's firewall on CrOS. It's actually a scoped > wrapper around DBus::FileDescriptor, not a platform file descriptor. I > would like to use it to facilitate some other similar functionality in > which I create a pipe and pass one end over DBus, so it seems like a > good idea to move ScopedFileDescriptor into the dbus library directly. > > BUG=chromium:481340 > TEST=FirewallHole unit tests still pass > STATUS=Fixed > R=keybuk, reillyg, stevenjb > > Committed: https://crrev.com/b44fbaabbe9f91e63ad8aa164609a6b31e0de57e > Cr-Commit-Position: refs/heads/master@{#327089} TBR=keybuk@chromium.org,reillyg@chromium.org,stevenjb@chromium.org,cmasone@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:481340 Committed: https://crrev.com/ee9dc849ffa2df2820381c31d5ba8200774d287a Cr-Commit-Position: refs/heads/master@{#327103}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -32 lines) Patch
M chromeos/network/firewall_hole.h View 3 chunks +17 lines, -6 lines 0 comments Download
M chromeos/network/firewall_hole.cc View 5 chunks +14 lines, -7 lines 0 comments Download
M dbus/file_descriptor.h View 3 chunks +0 lines, -10 lines 0 comments Download
M dbus/file_descriptor.cc View 1 chunk +0 lines, -9 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
spang
Created Revert of Move ScopedFileDescriptor to dbus/file_descriptor.h
5 years, 7 months ago (2015-04-27 19:44:06 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1108893003/1
5 years, 7 months ago (2015-04-27 19:44:40 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-04-27 19:45:53 UTC) #3
commit-bot: I haz the power
5 years, 7 months ago (2015-04-27 19:46:54 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ee9dc849ffa2df2820381c31d5ba8200774d287a
Cr-Commit-Position: refs/heads/master@{#327103}

Powered by Google App Engine
This is Rietveld 408576698