Index: chromeos/network/firewall_hole.h |
diff --git a/chromeos/network/firewall_hole.h b/chromeos/network/firewall_hole.h |
index e6d119d961c91cc831a9da4a16332cbfbf1e5e06..2bd678813210ee0f142e2c1e90590b903a3132a6 100644 |
--- a/chromeos/network/firewall_hole.h |
+++ b/chromeos/network/firewall_hole.h |
@@ -11,7 +11,10 @@ |
#include "base/callback_forward.h" |
#include "base/memory/scoped_ptr.h" |
#include "chromeos/chromeos_export.h" |
-#include "dbus/file_descriptor.h" |
+ |
+namespace dbus { |
+class FileDescriptor; |
+} |
namespace chromeos { |
@@ -25,6 +28,14 @@ |
}; |
typedef base::Callback<void(scoped_ptr<FirewallHole>)> OpenCallback; |
+ |
+ // This provides a simple way to pass around file descriptors since they must |
+ // be closed on a thread that is allowed to perform I/O. |
+ struct FileDescriptorDeleter { |
+ void CHROMEOS_EXPORT operator()(dbus::FileDescriptor* fd); |
+ }; |
+ typedef scoped_ptr<dbus::FileDescriptor, FileDescriptorDeleter> |
+ ScopedFileDescriptor; |
// Opens a port on the system firewall for the given network interface (or all |
// interfaces if |interface| is ""). The hole will be closed when the object |
@@ -40,28 +51,28 @@ |
static void RequestPortAccess(PortType type, |
uint16_t port, |
const std::string& interface, |
- dbus::ScopedFileDescriptor lifeline_local, |
- dbus::ScopedFileDescriptor lifeline_remote, |
+ ScopedFileDescriptor lifeline_local, |
+ ScopedFileDescriptor lifeline_remote, |
const OpenCallback& callback); |
static void PortAccessGranted(PortType type, |
uint16_t port, |
const std::string& interface, |
- dbus::ScopedFileDescriptor lifeline_fd, |
+ ScopedFileDescriptor lifeline_fd, |
const FirewallHole::OpenCallback& callback, |
bool success); |
FirewallHole(PortType type, |
uint16_t port, |
const std::string& interface, |
- dbus::ScopedFileDescriptor lifeline_fd); |
+ ScopedFileDescriptor lifeline_fd); |
const PortType type_; |
const uint16_t port_; |
const std::string interface_; |
// A file descriptor used by firewalld to track the lifetime of this process. |
- dbus::ScopedFileDescriptor lifeline_fd_; |
+ ScopedFileDescriptor lifeline_fd_; |
}; |
} // namespace chromeos |