Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(753)

Issue 1108863002: Revert "Ensure we properly set PageTransition for iframes." (Closed)

Created:
5 years, 8 months ago by ncarter (slow)
Modified:
5 years, 8 months ago
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, creis+watch_chromium.org, nasko+codewatch_chromium.org, jam, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert "Ensure we properly set PageTransition for iframes." This reverts commit 735aa03be45990a5e2feb3c38087e6f76eb920ac AKA refs/heads/master@{#326404} Reverting because it caused a bug which is currently the top crasher on canary. Original description: Ensure we properly set PageTransition for iframes. We currently don't set subframe navigations as manual when it isn't the first navigation of the iframe. Also, we don't propagate the state correctly in the case of a cross-process transition. Original Review URL: https://codereview.chromium.org/1002953004 Original Cr-Commit-Position: refs/heads/master@{#326404} TBR=creis@chromium.org, japhet@chromium.org BUG=464014, 480839 Committed: https://crrev.com/94144d4dd7f594efcc4efd41a7ae424e7078a338 Cr-Commit-Position: refs/heads/master@{#327100}

Patch Set 1 #

Patch Set 2 : merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -88 lines) Patch
M content/browser/frame_host/navigator.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/frame_host/navigator_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/frame_host/navigator_impl.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M content/browser/frame_host/render_frame_host_impl.cc View 1 chunk +1 line, -7 lines 0 comments Download
M content/browser/security_exploit_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/site_per_process_browsertest.cc View 2 chunks +0 lines, -30 lines 0 comments Download
M content/renderer/render_frame_impl.cc View 1 5 chunks +12 lines, -35 lines 0 comments Download
M content/test/test_frame_navigation_observer.h View 4 chunks +1 line, -8 lines 0 comments Download
M content/test/test_frame_navigation_observer.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 10 (4 generated)
ncarter (slow)
5 years, 8 months ago (2015-04-27 16:55:00 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1108863002/1
5 years, 8 months ago (2015-04-27 16:55:51 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_compile_dbg_32_ng/builds/46886) ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, ...
5 years, 8 months ago (2015-04-27 17:00:11 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1108863002/20001
5 years, 8 months ago (2015-04-27 17:32:06 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 8 months ago (2015-04-27 19:21:58 UTC) #9
commit-bot: I haz the power
5 years, 8 months ago (2015-04-27 19:22:54 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/94144d4dd7f594efcc4efd41a7ae424e7078a338
Cr-Commit-Position: refs/heads/master@{#327100}

Powered by Google App Engine
This is Rietveld 408576698