content/test/test_frame_navigation_observer.cc - Issue 1108863002: Revert "Ensure we properly set PageTransition for iframes."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/test/test_frame_navigation_observer.cc

Issue 1108863002: Revert "Ensure we properly set PageTransition for iframes." (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: merge Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/test/test_frame_navigation_observer.cc

diff --git a/content/test/test_frame_navigation_observer.cc b/content/test/test_frame_navigation_observer.cc

index e3cbccecd1b8a8f6698031e657c470a48040a65c..c6d151bc2ee2360b4ef2e40d4628d8036d569034 100644

--- a/content/test/test_frame_navigation_observer.cc

+++ b/content/test/test_frame_navigation_observer.cc

@@ -67,7 +67,6 @@ void TestFrameNavigationObserver::DidNavigateAnyFrame(

++navigations_completed_;

if (navigations_completed_ == number_of_navigations_) {

- load_committed_details_ = details;

navigation_started_ = false;

message_loop_runner_->Quit();

}

« no previous file with comments | « content/test/test_frame_navigation_observer.h ('k') | no next file » | no next file with comments »