Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1473)

Unified Diff: chrome/browser/ui/intents/web_intents_model.cc

Issue 11087022: intents: Change default_service_url() to return a const-ref. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rm virtual dtor Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/intents/web_intents_model.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/intents/web_intents_model.cc
diff --git a/chrome/browser/ui/intents/web_intents_model.cc b/chrome/browser/ui/intents/web_intents_model.cc
index 188132827679ac89b45947a5685909f6aee56525..34d5e1c4b72797b868fec0a3b2b2bd166aca6e02 100644
--- a/chrome/browser/ui/intents/web_intents_model.cc
+++ b/chrome/browser/ui/intents/web_intents_model.cc
@@ -3,27 +3,27 @@
// found in the LICENSE file.
#include "chrome/browser/ui/intents/web_intents_model.h"
+
#include "base/string_split.h"
#include "base/string_util.h"
#include "base/stringprintf.h"
#include "base/utf_string_conversions.h"
-#include "chrome/browser/intents/default_web_intent_service.h"
#include "chrome/browser/intents/web_intents_registry.h"
WebIntentsTreeNode::WebIntentsTreeNode()
- : ui::TreeNode<WebIntentsTreeNode>(string16()),
- type_(TYPE_ROOT) {}
+ : ui::TreeNode<WebIntentsTreeNode>(string16()),
+ type_(TYPE_ROOT) {}
WebIntentsTreeNode::WebIntentsTreeNode(const string16& title)
- : ui::TreeNode<WebIntentsTreeNode>(title),
- type_(TYPE_ORIGIN) {}
+ : ui::TreeNode<WebIntentsTreeNode>(title),
+ type_(TYPE_ORIGIN) {}
WebIntentsTreeNode::~WebIntentsTreeNode() {}
ServiceTreeNode::ServiceTreeNode(const string16& title)
- : WebIntentsTreeNode(title, WebIntentsTreeNode::TYPE_SERVICE),
- blocked_(false),
- disabled_(false) {}
+ : WebIntentsTreeNode(title, WebIntentsTreeNode::TYPE_SERVICE),
+ blocked_(false),
+ disabled_(false) {}
ServiceTreeNode::~ServiceTreeNode() {}
@@ -58,7 +58,7 @@ string16 WebIntentsModel::GetTreeNodeId(WebIntentsTreeNode* node) {
return string16();
}
-WebIntentsTreeNode* WebIntentsModel::GetTreeNode(std::string path_id) {
+WebIntentsTreeNode* WebIntentsModel::GetTreeNode(const std::string& path_id) {
if (path_id.empty())
return GetRoot();
« no previous file with comments | « chrome/browser/ui/intents/web_intents_model.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698