intents: Change default_service_url() to return a const-ref.

chrome/browser/ui/intents/web_intents_model.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/intents/web_intents_model.h"
+
 #include "base/string_split.h"
 #include "base/string_util.h"
 #include "base/stringprintf.h"
 #include "base/utf_string_conversions.h"
-#include "chrome/browser/intents/default_web_intent_service.h"
 #include "chrome/browser/intents/web_intents_registry.h"
 
 WebIntentsTreeNode::WebIntentsTreeNode()
-  : ui::TreeNode<WebIntentsTreeNode>(string16()),
-    type_(TYPE_ROOT) {}
+    : ui::TreeNode<WebIntentsTreeNode>(string16()),
+      type_(TYPE_ROOT) {}
 
 WebIntentsTreeNode::WebIntentsTreeNode(const string16& title)
-  : ui::TreeNode<WebIntentsTreeNode>(title),
-    type_(TYPE_ORIGIN) {}
+    : ui::TreeNode<WebIntentsTreeNode>(title),
+      type_(TYPE_ORIGIN) {}
 
 WebIntentsTreeNode::~WebIntentsTreeNode() {}
 
 ServiceTreeNode::ServiceTreeNode(const string16& title)
-  : WebIntentsTreeNode(title, WebIntentsTreeNode::TYPE_SERVICE),
-    blocked_(false),
-    disabled_(false) {}
+    : WebIntentsTreeNode(title, WebIntentsTreeNode::TYPE_SERVICE),
+      blocked_(false),
+      disabled_(false) {}
 
 ServiceTreeNode::~ServiceTreeNode() {}
 
 WebIntentsModel::WebIntentsModel(WebIntentsRegistry* intents_registry)
     : ui::TreeNodeModel<WebIntentsTreeNode>(new WebIntentsTreeNode()),
       intents_registry_(intents_registry),
       batch_update_(0) {
   LoadModel();
 }
 
@@ skipping 14 matching lines @@
 string16 WebIntentsModel::GetTreeNodeId(WebIntentsTreeNode* node) {
   if (node->Type() == WebIntentsTreeNode::TYPE_ORIGIN)
     return node->GetTitle();
 
   // TODO(gbillock): handle TYPE_SERVICE when/if we ever want to do
   // specific managing of them.
 
   return string16();
 }
 
-WebIntentsTreeNode* WebIntentsModel::GetTreeNode(std::string path_id) {
+WebIntentsTreeNode* WebIntentsModel::GetTreeNode(const std::string& path_id) {
   if (path_id.empty())
     return GetRoot();
 
   std::vector<std::string> node_ids;
   base::SplitString(path_id, ',', &node_ids);
 
   for (int i = 0; i < GetRoot()->child_count(); ++i) {
     WebIntentsTreeNode* node = GetRoot()->GetChild(i);
     if (UTF16ToUTF8(node->GetTitle()) == node_ids[0]) {
       if (node_ids.size() == 1)
@@ skipping 94 matching lines @@
 
 void WebIntentsModel::NotifyObserverEndBatch() {
   // Only notify the observers if this is the outermost call to EndBatch() if
   // called in a nested manner.
   if (--batch_update_ == 0) {
     FOR_EACH_OBSERVER(Observer,
                       intents_observer_list_,
                       TreeModelEndBatch(this));
   }
 }