Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(595)

Issue 1108683002: Fix the WebUIWebViewBrowserTest.AddContentScriptsWithNewWindowAPI. (Closed)

Created:
5 years, 8 months ago by Xi Han
Modified:
5 years, 8 months ago
Reviewers:
xiyuan
CC:
chromium-reviews, Fady Samuel
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix the WebUIWebViewBrowserTest.AddContentScriptsWithNewWindowAPI. BUG=461052 Committed: https://crrev.com/b1961bc5bf45e7eedea19db28d6f3e2c8d031c7c Cr-Commit-Position: refs/heads/master@{#326883}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/test/data/webui/webview_execute_script_test.js View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
Xi Han
5 years, 8 months ago (2015-04-24 20:21:56 UTC) #2
xiyuan
lgtm
5 years, 8 months ago (2015-04-24 20:29:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1108683002/20001
5 years, 8 months ago (2015-04-24 20:32:04 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 8 months ago (2015-04-24 21:40:56 UTC) #6
commit-bot: I haz the power
5 years, 8 months ago (2015-04-24 21:42:51 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b1961bc5bf45e7eedea19db28d6f3e2c8d031c7c
Cr-Commit-Position: refs/heads/master@{#326883}

Powered by Google App Engine
This is Rietveld 408576698