chrome/test/data/webui/webview_execute_script_test.js - Issue 1108683002: Fix the WebUIWebViewBrowserTest.AddContentScriptsWithNewWindowAPI.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/data/webui/webview_execute_script_test.js

Issue 1108683002: Fix the WebUIWebViewBrowserTest.AddContentScriptsWithNewWindowAPI. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/test/data/webui/webview_execute_script_test.js

diff --git a/chrome/test/data/webui/webview_execute_script_test.js b/chrome/test/data/webui/webview_execute_script_test.js

index 277c12ff565bf9fabc6549bb41f80abdd9e46306..84b768bc564b44b50c15ec03045bc23e71411d14 100644

--- a/chrome/test/data/webui/webview_execute_script_test.js

+++ b/chrome/test/data/webui/webview_execute_script_test.js

@@ -347,7 +347,7 @@ function testAddContentScriptsWithNewWindowAPI(url) {

});

window.addEventListener('message', function(e) {

- if (e.source != newwebview.contentWindow)

+ if (!newwebview || e.source != newwebview.contentWindow)

return;

var data = JSON.parse(e.data);

if (data == RESPONSE_FROM_COMM_CHANNEL_1 &&

« no previous file with comments | « no previous file | no next file » | no next file with comments »